Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use upstream k8s version lib #657

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

n3wscott
Copy link
Contributor

@n3wscott n3wscott commented Feb 7, 2022

Summary

Use the upsteam k8s version lib. See kubernetes-sigs/release-utils#31 kubernetes-sigs/release-utils#29 kubernetes-sigs/release-utils#28

Note: there is a change around the pproc flag, if the flag is provided, the server will host the pproc endpoints. This use to be guarded by the lack of ldflags setting gitVersion. (though, would have had a bug if someone installed the server via go install or go get)

Ticket Link

See kubernetes-sigs/release-utils#23

Release Note

pproc flag use to be ignored for production builds, no longer ignored.

Signed-off-by: Scott Nichols <n3wscott@chainguard.dev>
@n3wscott n3wscott requested a review from a team as a code owner February 7, 2022 18:31
@lukehinds
Copy link
Member

lukehinds commented Feb 7, 2022

What's the advantage of using the upstream version , is the current implementation lacking somehow?

edit: my main concern here is we are pulling in quite a few new deps, for what is more of a cosmetic change (iirc?)

@n3wscott
Copy link
Contributor Author

n3wscott commented Feb 7, 2022

Deleting code and using a common lib to do the same thing. The main issue is this code is duplicated around the cloud native landscape about 300 times so we are working to centralize it. See also sigstore/cosign#1413

edit: the new deps in .sum file are not added to the binary. There is only two new deps: the ascii text and the upstream k8s lib. The rest are just in the module at other paths.

@lukehinds lukehinds merged commit b1b97fb into sigstore:main Feb 10, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants