Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of SIG CLI charter #2137

Closed
wants to merge 2 commits into from

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented May 8, 2018

  • First draft of SIG CLI charter
  • Updates SIG CLI chairs and leads.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 8, 2018
@k8s-ci-robot k8s-ci-robot requested review from cblecker and soltysh May 8, 2018 23:21
@k8s-ci-robot
Copy link
Contributor

Hi @seans3. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels May 8, 2018
@seans3
Copy link
Contributor Author

seans3 commented May 8, 2018

/assign pwittrock

@seans3
Copy link
Contributor Author

seans3 commented May 8, 2018

/assign monopole

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: pwittrock

Assign the PR to them by writing /assign @pwittrock in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seans3 seans3 force-pushed the sig-cli-charter branch from 5acb11e to 9e04b7c Compare May 9, 2018 00:24
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nice but this lgtm. Thanks for putting this together Sean!

* *MUST* be an escalation point for technical discussions and decisions in the
subproject.
* *MUST* set milestone priorities for subproject or delegate this responsibility.
* *MUST* remain active in the role. A Subproject Owner Will be automatically
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Will/will

* SIG CLI meetings
* *SHOULD* be facilitated by Chairs unless delegated to specific Members.
* *SHOULD* be held bi-weekly on [Zoom](https://zoom.us/my/sigcli) video
conference every other Wednesday at 9am PST.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to https://www.timeanddate.com/ so that's easier for folks from other TZ to convert that.


The Command Line Interface SIG (SIG CLI) is responsible for kubectl and
related tools. This group focuses on command line tools and
libraries to interface with Kubernetes API's.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libraries for command line tools

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a necessary edit, please fix!

@k8s-ci-robot
Copy link
Contributor

@seans3: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2018
@cblecker cblecker removed their request for review May 20, 2018 23:46
@pwittrock
Copy link
Member

@jbeda Lets hold off on this one until it is refactored into the new format. @seans3 is out for the next week, but can restructure when he is back.

@philips
Copy link
Contributor

philips commented Jul 20, 2018

Thank you for your patience as we work to your SIG charter merged.

Through the process of reviewing the first 11 charters the Steering Committee (SC) found a lot of copy/paste language caused by our poorly designed initial charter template. To fix this there is a new SIG charter template which focuses on the main things we want to see in charters: scope and responsibilities.

Please consider updating to this charter template and putting focus into the scope and responsibilities. SC members will focus more on a deep review of scope more than anything else and using this template will help with that focus.

@bgrant0607
Copy link
Member

Aside from refactoring the charter to match the new template, I think the main thing to resolve is the scope.

At some point there was some ambition to cover other CLIs than just kubectl, such as kubeadm, minikube, kubefed, etc. Ideally there would be common conventions among the project's command-line tools, or at least for categories of types of tools (e.g., imagine Unix tools with no common conventions). However, I don't think that has happened much. The possibility of SIG CLI developing additional capabilities and/or tools has been raised, also, but there hasn't been critical mass to do so. Such tools have been developed in the ecosystem instead, which is ok, and would even be desirable, if they were more discoverable by users.

We could potentially start the scope as just kubectl and reserve the possibility of expanding it later.

@philips
Copy link
Contributor

philips commented Aug 9, 2018

@bgrant0607 AFAICT the scope of the SIG has been kubectl. I think we should start from the scope as understood by the SIG today in an effort to merge their charter in a reasonable time frame.

@seans3 are you back and able to work on this?

@seans3 seans3 closed this Aug 9, 2018
@philips
Copy link
Contributor

philips commented Aug 15, 2018

The new PR for this charter is #2453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants