First version of SIG CLI Charter #2453

seans3 · 2018-08-02T00:22:40Z

Implements the initial governance rules for SIG CLI.

cblecker · 2018-08-02T00:39:20Z

@kubernetes/steering-committee
/committee steering

spiffxp · 2018-08-09T16:18:13Z

Hi @seans3 is this a redo of #2137? If so please close that one and point to here

philips · 2018-08-10T00:10:29Z

cc @bgrant0607 SIG CLI review

philips · 2018-08-11T00:59:24Z

sig-cli/charter.md

+
+SIG CLI code include command line tools and binaries for working with Kubernetes
+API's. Examples of these binaries include: kubectl and kustomize.
+


Could you please link to this: https://github.com/kubernetes/community/blob/master/sig-cli/README.md#subprojects

philips · 2018-08-11T01:00:15Z

sig-cli/charter.md

+### Out of scope
+
+SIG CLI is NOT responsible for defining the Kubernetes API that it
+interfaces with. The Kubernetes API is the responsibility of SIG API Machinery.


It is probably worthwhile to call out all of the other CLIs that SIG CLI doesn't oversee and why. For example kubeadm, kube-apiserver, etc, etc.

The why being that these CLIs don't interact with the API I suppose.

There's nothing stopping us from looking after them, but nobody reached out to us for so, that's why since none of us (sig participants) authored these we don't feel like owning them nor don't want to 'steal' other's work.

On a second note, I think that calling out what we don't oversee might be an overkill. IMO it's sufficient we clearly define ownership in the previous paragraph. The fact that API is being mentioned here is specifically to call out that we don't and never will change the API, that's sig-apimachinery responsibility.

I am not going to hold strong on this point. But, I do still believe it would be helpful to provide illustrative counter examples.

To recap, following Maciej's advice:

We won't mention kubeadm or kube-apiserver.

We will keep the "Out of scope" statement as is.

If misunderstood, please let me know.

I don't think it's helpful to lump all Kubernetes components, such as kube-apiserver, under "CLI".

I do think it's helpful to indicate that SIG CLI doesn't own all conceivable command-line tools within the project: kubeadm, kops, kompose, kubefed, etc.

I would add something like:

SIG CLI is not responsible for command-line tools built and maintained by other SIGs, such as kubeadm, which is owned by SIG Cluster Lifecycle.

(Just to include one example and not make it appear to be an exhaustive list.)

liggitt · 2018-08-11T01:05:35Z

sigs.yaml

    label: cli
    leadership:
      chairs:
+      - name: Maciej Szulik


duplicated entry

Nope, there are chairs which are responsible for organizational issue with sig and leads which are responsible for technicalities. Sean and I are both chairs, on top of that Phil and I are tech-leads, which makes me deserve double entry 🥇

liggitt · 2018-08-11T01:06:27Z

sigs.yaml

+      - name: Maciej Szulik
+        github: soltysh
+        company: Red Hat
+      - name: Sean Sullivan


seems like it might be better to make chair changes separately from the charter addition

I'd just move this to separate commit, which should be sufficient.

liggitt · 2018-08-11T01:08:34Z

sig-cli/charter.md

+SIG CLI code include command line tools and binaries for working with Kubernetes
+API's. Examples of these binaries include: kubectl and kustomize.
+
+### Out of scope


would it make sense to include some "Cross-cutting and Externally Facing Processes" aspects of how sig-cli collaborates with the sigs that own other binaries to improve command consistency?

Not quite sure what you mean by that?

spzala · 2018-08-18T01:39:38Z

sig-cli/charter.md

+
+
+[sig-governance]: https://github.com/kubernetes/community/blob/master/committee-steering/governance/sig-governance.md
+[sigs.yaml]: https://github.com/kubernetes/community/blob/master/sigs.yaml#L487


Use of sigs.yaml with line number is not recommended by the latest changes in the charter template for a good reason that the number for sig section may not remain same - e0d60fd

bgrant0607

Thanks. Once my suggested changes are made I think this can be merged.

bgrant0607 · 2018-08-24T18:01:01Z

sig-cli/charter.md

+
+### In scope
+
+SIG CLI section in [sigs.yaml]


Please link to the corresponding information in the sig-cli README instead.

bgrant0607 · 2018-08-24T18:08:36Z

sig-cli/charter.md

+### Out of scope
+
+SIG CLI is NOT responsible for defining the Kubernetes API that it
+interfaces with. The Kubernetes API is the responsibility of SIG API Machinery.


I don't think it's helpful to lump all Kubernetes components, such as kube-apiserver, under "CLI".

I do think it's helpful to indicate that SIG CLI doesn't own all conceivable command-line tools within the project: kubeadm, kops, kompose, kubefed, etc.

I would add something like:

SIG CLI is not responsible for command-line tools built and maintained by other SIGs, such as kubeadm, which is owned by SIG Cluster Lifecycle.

(Just to include one example and not make it appear to be an exhaustive list.)

bgrant0607 · 2018-08-24T18:10:08Z

sig-cli/charter.md

+
+#### Code, Binaries and Services
+
+SIG CLI code include command line tools and binaries for working with Kubernetes


I suggest "general-purpose command-line tools and binaries" as a way to distinguish these from the special-purpose tools built by other SIGs.

philips · 2018-08-27T18:31:35Z

Since @pwittrock, @bgrant0607, and myself from the steering committee have all taken a look at this and #2137 I am going to approve this.

However, if @jbeda would like to take one final look as one of the designated Steering reviewers I will hold until EOD.

/lgtm
/approve
/hold

k8s-ci-robot · 2018-08-27T18:31:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~sig-cli/OWNERS~~ [philips]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

spiffxp · 2018-08-27T23:33:28Z

/lgtm
from me too, FWIW

philips · 2018-08-28T19:43:19Z

/hold cancel

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Aug 2, 2018

k8s-ci-robot requested review from calebamiles and soltysh August 2, 2018 00:22

k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Aug 2, 2018

First pass of SIG CLI charter

3b98068

seans3 force-pushed the sigcli-charter branch from 67a24dc to 3b98068 Compare August 2, 2018 00:41

philips suggested changes Aug 11, 2018

View reviewed changes

liggitt reviewed Aug 11, 2018

View reviewed changes

philips mentioned this pull request Aug 15, 2018

First draft of SIG CLI charter #2137

Closed

seans3 added 2 commits August 17, 2018 13:53

Added link to README

fe65b92

Moving leadership changes to another PR

8b2aac9

spzala reviewed Aug 18, 2018

View reviewed changes

bgrant0607 self-assigned this Aug 24, 2018

bgrant0607 reviewed Aug 24, 2018

View reviewed changes

Addressed comments on scope; Removed sigs.yaml

7ac2653

k8s-ci-robot assigned philips Aug 27, 2018

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 27, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2018

philips approved these changes Aug 27, 2018

View reviewed changes

k8s-ci-robot assigned spiffxp Aug 27, 2018

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2018

k8s-ci-robot merged commit ab4ada7 into kubernetes:master Aug 28, 2018

jdumars mentioned this pull request Aug 31, 2018

Charters Meta-issue kubernetes/steering#31

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First version of SIG CLI Charter #2453

First version of SIG CLI Charter #2453

seans3 commented Aug 2, 2018

cblecker commented Aug 2, 2018

spiffxp commented Aug 9, 2018

philips commented Aug 10, 2018

philips Aug 11, 2018

philips Aug 11, 2018

philips Aug 11, 2018

soltysh Aug 15, 2018

soltysh Aug 15, 2018

philips Aug 15, 2018

seans3 Aug 17, 2018

bgrant0607 Aug 24, 2018

liggitt Aug 11, 2018

soltysh Aug 15, 2018

liggitt Aug 11, 2018

soltysh Aug 15, 2018

liggitt Aug 11, 2018

soltysh Aug 15, 2018

spzala Aug 18, 2018

bgrant0607 left a comment

bgrant0607 Aug 24, 2018

bgrant0607 Aug 24, 2018

bgrant0607 Aug 24, 2018

philips commented Aug 27, 2018

k8s-ci-robot commented Aug 27, 2018

spiffxp commented Aug 27, 2018

philips commented Aug 28, 2018


		SIG CLI code include command line tools and binaries for working with Kubernetes
		API's. Examples of these binaries include: kubectl and kustomize.



		[sig-governance]: https://github.com/kubernetes/community/blob/master/committee-steering/governance/sig-governance.md
		[sigs.yaml]: https://github.com/kubernetes/community/blob/master/sigs.yaml#L487


		#### Code, Binaries and Services

		SIG CLI code include command line tools and binaries for working with Kubernetes

First version of SIG CLI Charter #2453

First version of SIG CLI Charter #2453

Conversation

seans3 commented Aug 2, 2018

cblecker commented Aug 2, 2018

spiffxp commented Aug 9, 2018

philips commented Aug 10, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bgrant0607 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

philips commented Aug 27, 2018

k8s-ci-robot commented Aug 27, 2018

spiffxp commented Aug 27, 2018

philips commented Aug 28, 2018