Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.16.5] Update to go1.13.4 #85019

Merged
merged 14 commits into from
Dec 19, 2019
Merged

[v1.16.5] Update to go1.13.4 #85019

merged 14 commits into from
Dec 19, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Nov 8, 2019 •
edited
Loading

Picks:

1.16-specific:

  • Move e2e flag copy into TestMain (same thing as e2e_node, done for e2e)

Before merge:

/cc @tpepper
/sig release

Kubernetes 1.16.5+ now requires go1.13.4+ to build

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 8, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Nov 8, 2019
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/ipvs area/kubeadm area/kubectl area/kubelet area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 8, 2019
@liggitt liggitt changed the title Update to go1.13.4 [v1.16] Update to go1.13.4 Nov 8, 2019
@liggitt
Move e2e_node flag copy into TestMain
b4eb759 
As of go1.13, test flags like test.timeout are registered lazily.
This means they are not available in package init() methods:

> Testing flags are now registered in the new Init function,
> which is invoked by the generated main function for the test.
> As a result, testing flags are now only registered when running
> a test binary, and packages that call flag.Parse during package
> initialization may cause tests to fail.

This moves the copy of CLI flags into TestMain, just prior to parse.
@liggitt
Move e2e flag copy into TestMain
78f96a5 
As of go1.13, test flags like test.timeout are registered lazily.
This means they are not available in package init() methods:

> Testing flags are now registered in the new Init function,
> which is invoked by the generated main function for the test.
> As a result, testing flags are now only registered when running
> a test binary, and packages that call flag.Parse during package
> initialization may cause tests to fail.

This moves the copy of CLI flags into TestMain, just prior to parse.
@liggitt
Fixup integration tests for TLS1.3
86d35ac
@liggitt
Fix hack/pin-dependency.sh for go1.13
1adf941
@liggitt
Update build to go1.13.4
ed157e1
@liggitt
bump kazel, bazel, gazelle
ab1d554 
hack/pin-dependency.sh k8s.io/repo-infra v0.0.1-alpha.1
To fix non-idempotent BUILD file generation

hack/pin-dependency.sh github.com/bazelbuild/bazel-gazelle v0.19.0
hack/pin-dependench.sh github.com/bazelbuild/buildtools 0.29.0
for go1.13.3 support

hack/lint-dependencies.sh

hack/pin-dependency.sh github.com/bazelbuild/buildtools v0.0.0-20190917191645-69366ca98f89
to pick up preferred version for repo-infra
@liggitt
bump github.com/go-openapi/jsonpointer v0.19.3
b2e0a20 
To fix bug exposed by reflect.Value#IsZero method added in go1.13
@liggitt
bump golang/x/... dependencies
98e2d59 
go1.13-levels
hack/pin-dependency.sh golang.org/x/crypto release-branch.go1.13
hack/pin-dependency.sh golang.org/x/net release-branch.go1.13
hack/pin-dependency.sh golang.org/x/tools release-branch.go1.13
hack/pin-dependency.sh golang.org/x/sys release-branch.go1.13

preferred levels for repos without 1.13 branches:
hack/pin-dependency.sh golang.org/x/lint v0.0.0-20190409202823-959b441ac422
hack/pin-dependency.sh golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45
hack/pin-dependency.sh golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e
hack/pin-dependency.sh golang.org/x/text v0.3.2
hack/pin-dependency.sh golang.org/x/time v0.0.0-20190308202827-9d24e82272b4
@liggitt
hack/lint-dependencies.sh
28b7e1f 
hack/pin-dependency.sh github.com/coreos/go-systemd v0.0.0-20181012123002-c6f51f82210d
hack/pin-dependency.sh github.com/go-openapi/swag v0.19.5
hack/pin-dependency.sh github.com/gregjones/httpcache v0.0.0-20180305231024-9cad4c3443a7
hack/pin-dependency.sh github.com/mailru/easyjson v0.0.0-20190626092158-b2ccc519800e
hack/pin-dependency.sh github.com/mattn/go-isatty v0.0.9
hack/pin-dependency.sh github.com/pkg/errors v0.8.1
hack/pin-dependency.sh github.com/spf13/pflag v1.0.5
hack/pin-dependency.sh gopkg.in/inf.v0 v0.9.1
hack/pin-dependency.sh k8s.io/klog v1.0.0

GO111MODULE=on go mod edit -dropreplace github.com/heketi/rest
GO111MODULE=on go mod edit -dropreplace github.com/heketi/utils
@liggitt
Copy link
Member Author

liggitt commented Dec 18, 2019

kubernetes/test-infra#15637 merged, rebased and retesting

@liggitt
Copy link
Member Author

liggitt commented Dec 18, 2019 •
edited
Loading

oh, we need to bump the kubekins image to pick up the go version change for 1.16 (e.g. kubernetes/test-infra#15133). xref kubernetes/test-infra#15637 (comment)

looks like kubernetes/test-infra#15627 will do that

@liggitt
Copy link
Member Author

liggitt commented Dec 18, 2019

/retest

@liggitt
Copy link
Member Author

liggitt commented Dec 18, 2019 •
edited
Loading

fixed the stray bazel file... all other CI jobs passed on the first try after bumping test-infra to go1.13 🎉

@liggitt
Copy link
Member Author

liggitt commented Dec 18, 2019

@tpepper this is green

cblecker
cblecker approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please specify that this is for 1.16.z in your release note?

Thank you for splitting up the commits.. makes it much easier to review in chunks.

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2019
@liggitt
Copy link
Member Author

liggitt commented Dec 18, 2019

Done

@cblecker
Copy link
Member

/hold cancel
:shipit:

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@idealhack idealhack added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 19, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 74eb9f2 into kubernetes:release-1.16 Dec 19, 2019
@liggitt liggitt deleted the go-1.13-1.16 branch December 19, 2019 15:32
@liggitt liggitt mentioned this pull request Jan 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idealhack idealhack idealhack approved these changes

@cblecker cblecker cblecker approved these changes

@tpepper tpepper Awaiting requested review from tpepper

Assignees

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/ipvs area/kubeadm area/kubectl area/kubelet area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
8 participants
@liggitt @tpepper @justaugustus @BenTheElder @cblecker @k8s-ci-robot @idealhack @neolit123