Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch k8s master CI to go1.13.4 #15113

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Nov 5, 2019

Changes CI for master to run using go1.13.4 (I think)

Prereq for green runs on kubernetes/kubernetes#82809

Once master switches to go1.13.4, other PRs will fail verify checks until kubernetes/kubernetes#82809 merges.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/images sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 5, 2019
@liggitt
Copy link
Member Author

liggitt commented Nov 5, 2019

/cc @BenTheElder

@cblecker cblecker self-assigned this Nov 5, 2019
@cblecker
Copy link
Member

cblecker commented Nov 5, 2019

I'm not sure if we need to bump master/experimental in the krte images too: images/krte/variants.yaml

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 5, 2019
@BenTheElder
Copy link
Member

it shouldn't be strictly necessary currently (we only use bazel with them at the moment) but I'd appreciate it.

KRTE currently only supports testing with kind specifically, but it's more or less kubekins-e2e optimized and dropping support for bootstrap.py, I'm using it to figure out what we can do to clean up the rest of the kubekins jobs someday..

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2019
@liggitt
Copy link
Member Author

liggitt commented Nov 5, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2019
@BenTheElder
Copy link
Member

/lgtm
/approve
note that we'll need to file an image bump to pick up these after this PR merges (CI will auto build / push them though)

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 5, 2019
@cblecker
Copy link
Member

cblecker commented Nov 6, 2019

/hold cancel
:shipit:

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2019
@stevekuznetsov
Copy link
Contributor

/hold cancel

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, liggitt, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 08082a3 into kubernetes:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants