Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch 1.16 test-integration to podutils, bump to go1.13.4 #15637

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Switch 1.16 test-integration to podutils, bump to go1.13.4 #15637

merged 1 commit into from
Dec 18, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Dec 18, 2019 •
edited
Loading

cc @BenTheElder @tpepper

Replicates #15113 and #15156 for release-1.16

/hold
once this merges, kubernetes/kubernetes#85019 will be required to merge before other 1.16 CI runs will succeed

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 18, 2019
@liggitt liggitt mentioned this pull request Dec 18, 2019
Merged
2 tasks
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/images area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 18, 2019
@justaugustus justaugustus mentioned this pull request Dec 18, 2019
Closed
@justaugustus
Copy link
Member

These jobs look like they could be forked, instead of done manually moving forward.
I've opened #15638 for this.

Release Engineering approval:
/lgtm
/approve

/assign @cjwagner @spiffxp

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2019
@BenTheElder
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2019
@liggitt
Copy link
Member Author

liggitt commented Dec 18, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit a9abec7 into kubernetes:master Dec 18, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 18, 2019
@k8s-ci-robot
Copy link
Contributor

@liggitt: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key 1.16.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.16.yaml
  • key integration.yaml using file config/jobs/kubernetes/sig-testing/integration.yaml

In response to this:

cc @BenTheElder @tpepper

Replicates #15113 and #15156 for release-1.16

/hold
once this merges, kubernetes/kubernetes#85019 will be required to merge before other 1.16 CI runs will succeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

liggitt
liggitt commented Dec 18, 2019
View reviewed changes
images/kubekins-e2e/variants.yaml
@@ -17,7 +17,7 @@ variants:
BAZEL_VERSION: 0.23.2
'1.16':
CONFIG: '1.16'
GO_VERSION: 1.12.12
GO_VERSION: 1.13.4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I think we need a rebuild/bump of kubekins images to pick this up

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cblecker @BenTheElder is there an automated process to bump these or do I need to open a PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like #15627 will do that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bump process is still somewhat manual, but will be merged later today.

@liggitt liggitt deleted the go1.13-1.16 branch December 20, 2019 03:52
@liggitt liggitt mentioned this pull request Jan 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@chases2 chases2 Awaiting requested review from chases2

Assignees

@spiffxp spiffxp

@justaugustus justaugustus

@cjwagner cjwagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/images area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
7 participants
@liggitt @justaugustus @BenTheElder @k8s-ci-robot @chases2 @spiffxp @cjwagner