-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update Kongponents to KCard milestone #1853
refactor: update Kongponents to KCard milestone #1853
Conversation
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Do not merge. This PR is up for review but not for merging. It will be merged in a coordinated fashion with other users of Kongponents’ alpha branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the PR version in the package.json
(which I know will be changed) this LGTM!
Removes the `<template #body>` and corresponding `</template>` tags from all uses of KCard as its `body` slot was removed. Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
I’ve updated the PR now to install the correct version of Kongponents. |
Removes the
<template #body>
and corresponding</template>
tags from all uses of KCard as itsbody
slot was removed.Replaces two instances of renamed class names.
Signed-off-by: Philipp Rudloff philipp.rudloff@konghq.com
Please refer to https://alpha--kongponents.netlify.app/guide/migrating-to-version-9.html#kcard for breaking changes in KCard. See also Kong/kongponents#1804 for the PR implementing those changes.
Tip: Use the "Hide whitespace" option to make the diff view easier to read: