refactor: update Kongponents to KCard milestone #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Do not merge. This PR is up for review but not for merging. It will be merged in a coordinated fashion with other users of Kongponents’ alpha branch. |
johncowen
reviewed
Dec 1, 2023
johncowen
approved these changes
Dec 5, 2023
added 4 commits
December 5, 2023 15:49
Removes the `<template #body>` and corresponding `</template>` tags from all uses of KCard as its `body` slot was removed. Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
|
I’ve updated the PR now to install the correct version of Kongponents. |
kleinfreund
changed the title
This was referenced Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
<template #body>and corresponding</template>tags from all uses of KCard as itsbodyslot was removed.Replaces two instances of renamed class names.
Signed-off-by: Philipp Rudloff philipp.rudloff@konghq.com
Please refer to https://alpha--kongponents.netlify.app/guide/migrating-to-version-9.html#kcard for breaking changes in KCard. See also Kong/kongponents#1804 for the PR implementing those changes.
Tip: Use the "Hide whitespace" option to make the diff view easier to read: