refactor: update Kongponents to KModal/KPrompt milestone #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
johncowen
approved these changes
Feb 5, 2024
added 4 commits
February 5, 2024 16:46
Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Rename `props.isVisible` to `props.visible`. Rename `canceled` event to `cancel`. Remove `header-content` slot use as it’s not needed anymore. The `props.title` string will be used automatically. Change `body-content` slot to default slot. Change `action-buttons` slot to `footer-actions` slot. Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Rename `props.isVisible` to `props.visible`. Rename `canceled` event to `cancel`. Change `body-content` slot to default slot. Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
This was referenced Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(KModal): address breaking changes
Rename
props.isVisibletoprops.visible.Rename
canceledevent tocancel.Remove
header-contentslot use as it’s not needed anymore. Theprops.titlestring will be used automatically.Change
body-contentslot to default slot.Change
action-buttonsslot tofooter-actionsslot.chore(KPrompt): address breaking changes
Rename
props.isVisibletoprops.visible.Rename
canceledevent tocancel.Change
body-contentslot to default slot.chore(zones): remove divider from single item dropdown item
Signed-off-by: Philipp Rudloff philipp.rudloff@konghq.com
Previous Kongponents v9 adoption PRs: