refactor: update Kongponents to KBreadcrumbs milestone #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3 tasks
|
Issue: There is a regression here that makes our tests fail: https://github.com/Kong/kongponents/pull/2097/files#r1539041246 |
johncowen
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
LGTM!
Made a small note of a minor thing offline:
Which we should be able to prevent by using itemMaxWidth here https://github.com/kumahq/kuma-gui/blob/master/src/app/application/components/app-view/AppView.vue#L10 I think
Gonna approve this anyway, we can follow up here in in a later PR.
added 3 commits
March 27, 2024 17:31
Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Replace `.k-breadcrumbs-item` with `.breadcrumbs-item-container`. Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(KBreadcrumbs): address breaking changes
Replace
.k-breadcrumbs-itemwith.breadcrumbs-item-container.Signed-off-by: Philipp Rudloff philipp.rudloff@konghq.com
Previous Kongponents v9 adoption PRs: