Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Unpin ubuntu-22.04 in Lint docs job #1973

Closed
schogges opened this issue Oct 15, 2024 · 0 comments · Fixed by #1975
Closed

CI: Unpin ubuntu-22.04 in Lint docs job #1973

schogges opened this issue Oct 15, 2024 · 0 comments · Fixed by #1975
Labels
kind/bug A bug triage/pending This issue will be looked at on the next triage meeting

Comments

@schogges
Copy link
Contributor

What happened?

We should unpin ubuntu-22.04 as soon as the issue is fixed upstream.
@schogges schogges added kind/bug A bug triage/pending This issue will be looked at on the next triage meeting labels Oct 15, 2024
@johncowen johncowen mentioned this issue Oct 17, 2024
Merged
johncowen added a commit that referenced this issue Oct 17, 2024
@johncowen
fix(ci): move vale action back to use ubuntu-latest / fix vocab dirs (#…
c4b59df 
…1975)

Back in #1972 following a suggested fix for a python error in the  vale GH action, we pinned ubuntu to what seemed like a working version. We've since seen that whilst it looked to be working, there were still errors deeper in the logs that somehow weren't caught by CI.

This PR:

1. Bumps the version of the vale GH action (I'm hoping/assuming this is why these errors weren't caught in CI?)
2. Changes the location of the Base vocabularies as a consequence of the GH action using `latest` for the version of vale to use i.e. vale version 3.something. The previous location was only supported in vale 2.something. This change fixed an error that has been appearing in CI logs over several PRs.
3. Puts things back to use ubuntu latest


Closes: #1973

---------

Signed-off-by: John Cowen <john.cowen@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug triage/pending This issue will be looked at on the next triage meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ci): move vale action back to use ubuntu-latest / fix vocab dirs johncowen/kuma-website
1 participant
@schogges