Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): move vale action back to use ubuntu-latest / fix vocab dirs #1975

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Oct 17, 2024

Back in #1972 following a suggested fix for a python error in the vale GH action, we pinned ubuntu to what seemed like a working version. We've since seen that whilst it looked to be working, there were still errors deeper in the logs that somehow weren't caught by CI.

This PR:

  1. Bumps the version of the vale GH action (I'm hoping/assuming this is why these errors weren't caught in CI?)
  2. Changes the location of the Base vocabularies as a consequence of the GH action using latest for the version of vale to use i.e. vale version 3.something. The previous location was only supported in vale 2.something. This change fixed an error that has been appearing in CI logs over several PRs.
  3. Puts things back to use ubuntu latest

Closes: #1973


Previous notes:

PR to experiment with fixes for a vale CI error thats appeared.

Related: #1972

The linked PR looked like it was a good fix (CI passed), but looking deeper into the errors in that passing PR run, showed a similar error that is now making CI fail.

Continuing to experiment/investigate

Signed-off-by: John Cowen <john.cowen@konghq.com>
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for kuma ready!

Name Link
🔨 Latest commit ba74bf2
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/6710e44c1c54f700087c87fa
😎 Deploy Preview https://deploy-preview-1975--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🟢 up 9 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 85 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: John Cowen <john.cowen@konghq.com>
Signed-off-by: John Cowen <john.cowen@konghq.com>
Signed-off-by: John Cowen <john.cowen@konghq.com>
Signed-off-by: John Cowen <john.cowen@konghq.com>
@johncowen johncowen marked this pull request as ready for review October 17, 2024 10:29
@johncowen johncowen requested a review from a team as a code owner October 17, 2024 10:29
@johncowen johncowen requested review from jijiechen and bartsmykla and removed request for a team October 17, 2024 10:29
@johncowen johncowen changed the title fix(ci): move back to ubuntu-latest fix(ci): move vale action back to use ubuntu-latest Oct 17, 2024
@johncowen johncowen changed the title fix(ci): move vale action back to use ubuntu-latest fix(ci): move vale action back to use ubuntu-latest / fix vocab dirs Oct 17, 2024
@johncowen johncowen merged commit c4b59df into kumahq:master Oct 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Unpin ubuntu-22.04 in Lint docs job
2 participants