feat(app/nav): add 2.9.x #1972
Merged
feat(app/nav): add 2.9.x #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: schogges <moritz.fleck@konghq.com>
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
schogges
requested review from
slonka and
lukidzi
and removed request for
a team
schogges
force-pushed
the
feat/app/_data/docs_nav_kuma_2-9-x
branch
from
ffd7a06
to
9b53270
Compare
Signed-off-by: schogges <moritz.fleck@konghq.com>
schogges
force-pushed
the
feat/app/_data/docs_nav_kuma_2-9-x
branch
from
9b53270
to
31dbd03
Compare
johncowen
added a commit
that referenced
this pull request
Oct 17, 2024
…1975) Back in #1972 following a suggested fix for a python error in the vale GH action, we pinned ubuntu to what seemed like a working version. We've since seen that whilst it looked to be working, there were still errors deeper in the logs that somehow weren't caught by CI. This PR: 1. Bumps the version of the vale GH action (I'm hoping/assuming this is why these errors weren't caught in CI?) 2. Changes the location of the Base vocabularies as a consequence of the GH action using `latest` for the version of vale to use i.e. vale version 3.something. The previous location was only supported in vale 2.something. This change fixed an error that has been appearing in CI logs over several PRs. 3. Puts things back to use ubuntu latest Closes: #1973 --------- Signed-off-by: John Cowen <john.cowen@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds navigation for
release-2.9.xand fixes404on/docs/2.9.x.Also fixes ci error in
Docs lintdue to error: externally-managed-environment on ubuntu ubuntu-24.04 when installingdocutils, by pin ubuntu to22.04.