feat: parameterize mev-boost args

[bharath-123]

Adds 2 new fields to the config file under the mev_params field:
mev_boost_image: <The mev-boost image, default is flashbots/mev-boost>
mev_boost_args: <The args of mev-boost. The default params are ["mev-boost", "--relay-check"]>

The behaviour is such that, mev-boost-args overrides all the args of mev-boost. No extra params are added.

Resolves #289

[barnabasbusa]

Could you please also update the readme?

[bharath-123]

will do

[bharath-123]

done @barnabasbusa

[barnabasbusa]

@parithosh can you please take a look at this, and ensure this satisfies #289 ?

[parithosh]

@parithosh can you please take a look at this, and ensure this satisfies #289 ?

on it

[parithosh]

Hmm, here's an example of a new mev-boost implimentation: https://github.com/mevsharp/mevsharp

To configure it, i can theoretically do this:

  mev_boost_image: mevsharp/mevsharp:latest
  mev_boost_extra_args: ["mevsharp","--genesis-fork-version=0x10000038","...."]

The issue is that since its a total override, i'd need to know the relay address in advance right? Or is the mev launcher auto-adding it?

I think the only way it can work neatly is if the mevsharp team adds config via env vars. Then we can set the env var similar to how it is today: "RELAYS": mev_boost_launcher.relay_end_points[0], to all images and we can override everything with ease.

Am i missing something or shall i go ahead and make this request of the mevsharp team?

[shakeshar]

Hmm, here's an example of a new mev-boost implimentation: https://github.com/mevsharp/mevsharp

To configure it, i can theoretically do this:

  mev_boost_image: mevsharp/mevsharp:latest
  mev_boost_extra_args: ["mevsharp","--genesis-fork-version=0x10000038","...."]

The issue is that since its a total override, i'd need to know the relay address in advance right? Or is the mev launcher auto-adding it?

I think the only way it can work neatly is if the mevsharp team adds config via env vars. Then we can set the env var similar to how it is today: "RELAYS": mev_boost_launcher.relay_end_points[0], to all images and we can override everything with ease.

Am i missing something or shall i go ahead and make this request of the mevsharp team?

We are testing this in the dev branch at the moment. if there are any specific/required variables you need please let me know
Commit: mevsharp/mevsharp@88520c3

[parithosh]

Hmm, here's an example of a new mev-boost implimentation: https://github.com/mevsharp/mevsharp
To configure it, i can theoretically do this:

  mev_boost_image: mevsharp/mevsharp:latest
  mev_boost_extra_args: ["mevsharp","--genesis-fork-version=0x10000038","...."]

The issue is that since its a total override, i'd need to know the relay address in advance right? Or is the mev launcher auto-adding it?
I think the only way it can work neatly is if the mevsharp team adds config via env vars. Then we can set the env var similar to how it is today: "RELAYS": mev_boost_launcher.relay_end_points[0], to all images and we can override everything with ease.
Am i missing something or shall i go ahead and make this request of the mevsharp team?

We are testing this in the dev branch at the moment. if there are any specific/required variables you need please let me know Commit: mevsharp/mevsharp@88520c3

Thanks!

Would be great to support the same ones as flashbots: https://github.com/flashbots/mev-boost/blob/bdabd0e6181990f9c3e0fef9f750b40f71d50c6c/cli/main.go#L35

[shakeshar]

Hmm, here's an example of a new mev-boost implimentation: https://github.com/mevsharp/mevsharp
To configure it, i can theoretically do this:

  mev_boost_image: mevsharp/mevsharp:latest
  mev_boost_extra_args: ["mevsharp","--genesis-fork-version=0x10000038","...."]

The issue is that since its a total override, i'd need to know the relay address in advance right? Or is the mev launcher auto-adding it?
I think the only way it can work neatly is if the mevsharp team adds config via env vars. Then we can set the env var similar to how it is today: "RELAYS": mev_boost_launcher.relay_end_points[0], to all images and we can override everything with ease.
Am i missing something or shall i go ahead and make this request of the mevsharp team?

We are testing this in the dev branch at the moment. if there are any specific/required variables you need please let me know Commit: mevsharp/mevsharp@88520c3

Thanks!

Would be great to support the same ones as flashbots: https://github.com/flashbots/mev-boost/blob/bdabd0e6181990f9c3e0fef9f750b40f71d50c6c/cli/main.go#L35

I followed mev-boost variables so basically Im using the same environment names. Please give it another try and don't hesitate to get back to me if you have any further concerns :)

/Stefan

[h4ck3rk3y]

@parithosh does this look okay to you now?

[parithosh]

PR itself seems to work as intended! Thank you @bharath-123 :D

@shakeshar , seems like mevsharp might need to add support for starting up relying purely on env vars as it currently fails expecting a network flag. But there is no custom network flag as far as i can see.

Minimal reproduction yaml:

additional_services: []
mev_type: mock
mev_params:
  mev_boost_image: mevsharp/mevsharp:latest
  mev_boost_args: ["mevsharp"]

[shakeshar]

PR itself seems to work as intended! Thank you @bharath-123 :D

@shakeshar , seems like mevsharp might need to add support for starting up relying purely on env vars as it currently fails expecting a network flag. But there is no custom network flag as far as i can see.

Minimal reproduction yaml:

additional_services: []
mev_type: mock
mev_params:
  mev_boost_image: mevsharp/mevsharp:latest
  mev_boost_args: ["mevsharp"]

Yes, that seems like a good idéa.
At the moment you can set the network using the CLI --network parameter, I could add this as an environment variable, however "network" is quite generic and could be used in other applications I reckon.
Do you have any preferred variable name you would like to use for this?

I.e in windows this would be set using "setx /M PREFERRED_KEY_NAME sepolia"

[parithosh]

PR itself seems to work as intended! Thank you @bharath-123 :D
@shakeshar , seems like mevsharp might need to add support for starting up relying purely on env vars as it currently fails expecting a network flag. But there is no custom network flag as far as i can see.
Minimal reproduction yaml:

additional_services: []
mev_type: mock
mev_params:
  mev_boost_image: mevsharp/mevsharp:latest
  mev_boost_args: ["mevsharp"]

Yes, that seems like a good idéa. At the moment you can set the network using the CLI --network parameter, I could add this as an environment variable, however "network" is quite generic and could be used in other applications I reckon. Do you have any preferred variable name you would like to use for this?

I.e in windows this would be set using "setx /M PREFERRED_KEY_NAME sepolia"

I think the mev-boost behaviour is probably useful to emulate here as well. So if you specify --network goerli, then it knows the GENESIS_FORK_VERSION value it needs to use for said network. If you want a custom network, you can just forego the --network flag and simply set the GENESIS_FORK_VERSION directly.

So the change on your side would be to crash only if network and GENESIS_FORK_VERSION (or flag variant) is missing.

[shakeshar]

mevsharp/mevsharp:latest

I just pushed an update, please get the latest image and try again and please get back to me with the result.

[shakeshar]

Added additional support for environmentvariables. It's been running in Testnet successfully for the past 24/h, get the latest package.
PR: mevsharp/mevsharp#120
@parithosh