Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RF using async memory #759

Merged
merged 4 commits into from
Nov 26, 2024
Merged

RF using async memory #759

merged 4 commits into from
Nov 26, 2024

Conversation

tilk
Copy link
Member

@tilk tilk commented Nov 25, 2024 •
edited
Loading

This PR is a step towards #737. For now, asynchronous memory is used to reduce the impact of the change.

TODO:

  • fix tests

@tilk tilk added the refactor Doesn't change functionality, but makes stuff nicer label Nov 25, 2024
@tilk tilk added the benchmark Benchmarks should be run for this change label Nov 26, 2024
@tilk tilk marked this pull request as ready for review November 26, 2024 09:21
@github-actions GitHub Actions
Copy link

Benchmarks summary

Performance benchmarks

aha-mont64 crc32 minver nettle-sha256 nsichneu slre statemate ud
0.417 (0.000) 0.513 (0.000) 0.337 (0.000) 0.655 (0.000) 0.361 (0.000) 0.290 (0.000) 0.326 (0.000) 0.431 (0.000)

You can view all the metrics here.

Synthesis benchmarks (basic)

Device utilisation: (ECP5) LUTs used as DFF: (ECP5) LUTs used as carry: (ECP5) LUTs used as ram: (ECP5) Max clock frequency (Fmax)
▼ 14610 (-1706) ▼ 4261 (-2016) 1428 (0) ▲ 1452 (+256) ▼ 52 (-2)

Synthesis benchmarks (full)

Device utilisation: (ECP5) LUTs used as DFF: (ECP5) LUTs used as carry: (ECP5) LUTs used as ram: (ECP5) Max clock frequency (Fmax)
▼ 22016 (-1955) ▼ 6876 (-2016) 1822 (0) ▲ 1504 (+256) ▼ 43 (-0)

tilk
tilk commented Nov 26, 2024
View reviewed changes
coreblocks/core_structs/rf.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions
Copy link

Benchmarks summary

Performance benchmarks

aha-mont64 crc32 minver nettle-sha256 nsichneu slre statemate ud
0.417 (0.000) 0.513 (0.000) 0.337 (0.000) 0.655 (0.000) 0.361 (0.000) 0.290 (0.000) 0.326 (0.000) 0.431 (0.000)

You can view all the metrics here.

Synthesis benchmarks (basic)

Device utilisation: (ECP5) LUTs used as DFF: (ECP5) LUTs used as carry: (ECP5) LUTs used as ram: (ECP5) Max clock frequency (Fmax)
▼ 14005 (-2311) ▼ 4261 (-2016) ▲ 1460 (+32) ▲ 1452 (+256) ▼ 50 (-4)

Synthesis benchmarks (full)

Device utilisation: (ECP5) LUTs used as DFF: (ECP5) LUTs used as carry: (ECP5) LUTs used as ram: (ECP5) Max clock frequency (Fmax)
▼ 22367 (-1604) ▼ 6876 (-2016) 1822 (0) ▲ 1504 (+256) ▲ 45 (+2)

@github-actions GitHub Actions
Copy link

Benchmarks summary

Performance benchmarks

aha-mont64 crc32 minver nettle-sha256 nsichneu slre statemate ud
0.417 (0.000) 0.513 (0.000) 0.337 (0.000) 0.655 (0.000) 0.361 (0.000) 0.290 (0.000) 0.326 (0.000) 0.431 (0.000)

You can view all the metrics here.

Synthesis benchmarks (basic)

Device utilisation: (ECP5) LUTs used as DFF: (ECP5) LUTs used as carry: (ECP5) LUTs used as ram: (ECP5) Max clock frequency (Fmax)
▼ 14346 (-2176) ▼ 4263 (-2016) 1490 (0) ▲ 1452 (+256) ▼ 50 (-3)

Synthesis benchmarks (full)

Device utilisation: (ECP5) LUTs used as DFF: (ECP5) LUTs used as carry: (ECP5) LUTs used as ram: (ECP5) Max clock frequency (Fmax)
▼ 21964 (-2013) ▼ 6878 (-2016) ▼ 1820 (-32) ▲ 1504 (+256) ▲ 48 (+4)

@tilk tilk merged commit 240734d into master Nov 26, 2024
14 checks passed
@tilk tilk deleted the tilk/memory-rf branch November 26, 2024 19:53
github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
@tilk
RF using async memory (#759)
98ecf5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalinf kalinf kalinf approved these changes

@piotro888 piotro888 piotro888 approved these changes

Assignees
No one assigned
Labels
benchmark Benchmarks should be run for this change refactor Doesn't change functionality, but makes stuff nicer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tilk @piotro888 @kalinf