Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Quine example #77

Merged
merged 5 commits into from
Nov 10, 2020
Merged

Add Quine example #77

merged 5 commits into from
Nov 10, 2020

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Oct 30, 2020

What does this PR do?

Adds a quine example in the README

$ kourou-dev sdk:execute --print-raw --code '(
  function quine() {
    const sq = String.fromCharCode(39);
    const lp = String.fromCharCode(40);
    const rp = String.fromCharCode(41);

    console.log("kourou-dev sdk:execute --print-raw --code " + sq + lp + quine.toString() + rp + lp + rp + ";" + sq)
  }
)()' > result.txt

$ cat result.txt 
kourou-dev sdk:execute --print-raw --code '(function quine() {
    const sq = String.fromCharCode(39);
    const lp = String.fromCharCode(40);
    const rp = String.fromCharCode(41);

    console.log("kourou-dev sdk:execute --print-raw --code " + sq + lp + quine.toString() + rp + lp + rp + ";" + sq)
  })();'

Other Changes

  • add the print-raw option to print only the script output

@Aschen Aschen self-assigned this Oct 30, 2020
@scottinet
Copy link
Contributor

What's the purpose of documentation that?

@Aschen
Copy link
Contributor Author

Aschen commented Nov 2, 2020

What's the purpose of documentation that?

Fun?

@scottinet
Copy link
Contributor

It might be, but since kourou is meant for the average user, I'm afraid that it's more confusing than anything.

@Aschen
Copy link
Contributor Author

Aschen commented Nov 2, 2020

It might be, but since kourou is meant for the average user, I'm afraid that it's more confusing than anything.

We already have the small paragraph about Kourou naming 😅

Maybe a warning saying that this is for recreational purpose only?

IMHO it is interesting to develop the IT culture of our users 😄

xbill82
xbill82 approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@xbill82 xbill82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@jenow jenow merged commit 5e59fcc into develop Nov 10, 2020
@jenow jenow deleted the add-quine branch November 10, 2020 16:26
@Aschen Aschen mentioned this pull request Feb 8, 2021
Merged
Aschen added a commit that referenced this pull request Feb 8, 2021
@Aschen
Release 0.18.0 (#96)
f77bd68 
# [0.18.0](https://github.com/kuzzleio/kourou/releases/tag/0.18.0) (2021-02-08)


#### New features

- [ [#82](#82) ] Add an option to export data in a format compatible with Kuzzle fixtures   ([jenow](https://github.com/jenow))
- [ [#81](#81) ] Add es:migrate command   ([alexandrebouthinon](https://github.com/alexandrebouthinon))

#### Enhancements

- [ [#93](#93) ] Update app template   ([Aschen](https://github.com/Aschen))
- [ [#92](#92) ] Add yaml support for vault   ([Aschen](https://github.com/Aschen))

#### Others

- [ [#77](#77) ] Add Quine example   ([Aschen](https://github.com/Aschen))
---
@Aschen Aschen mentioned this pull request Feb 25, 2021
Merged
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenow jenow jenow approved these changes

@xbill82 xbill82 xbill82 approved these changes

Assignees

@Aschen Aschen

Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Aschen @scottinet @jenow @xbill82