Update app template #93
Conversation
Aschen
force-pushed
the
update-app-template
branch
from
3e1abce to
aa1bd34
Compare
| @@ -0,0 +1,47 @@ | |||
| name: Pull request checks | |||
There was a problem hiding this comment.
is it a good idea to scaffold the github actions? Just wondering, because this is pretty much our internal workflow: is the whole community meant to use it?
At the same time, this is not really harmful, yet very useful to us. I don't really have an opinion, just asking about your strategy here.
There was a problem hiding this comment.
IMHO Github actions are part of the standard Kuzzle workflow which includes a linter and functional tests (like Vue.js/Webpack does if I remember well)
If they don't want to use it they can just delete the files but IMHO users shouldn't
There was a problem hiding this comment.
I partly agree with Luca. Maybe we should however remove the deployment part which can be very different depending on the use case
| context: ./backend | ||
| file: ./backend/Dockerfile | ||
| push: true | ||
| tags: registry.gitlab.com/kuzzle/<CHANGE-ME>:latest |
There was a problem hiding this comment.
Is there a place where we give instructions to come here and update these ?
There was a problem hiding this comment.
No, but as we agreed, the deployment part is now removed
# [0.18.0](https://github.com/kuzzleio/kourou/releases/tag/0.18.0) (2021-02-08) #### New features - [ [#82](#82) ] Add an option to export data in a format compatible with Kuzzle fixtures ([jenow](https://github.com/jenow)) - [ [#81](#81) ] Add es:migrate command ([alexandrebouthinon](https://github.com/alexandrebouthinon)) #### Enhancements - [ [#93](#93) ] Update app template ([Aschen](https://github.com/Aschen)) - [ [#92](#92) ] Add yaml support for vault ([Aschen](https://github.com/Aschen)) #### Others - [ [#77](#77) ] Add Quine example ([Aschen](https://github.com/Aschen)) ---
|
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What does this PR do?
Update the application template: