Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hive Testing: eth_getBlockByHash #269

Closed
3 tasks done
Tracked by #264
fmoletta opened this issue Aug 15, 2024 · 0 comments · Fixed by #304
Closed
3 tasks done
Tracked by #264

Hive Testing: eth_getBlockByHash #269

fmoletta opened this issue Aug 15, 2024 · 0 comments · Fixed by #304
Assignees
@avilagaston9
Labels
ef-tests Hive tests, execution-spec-tests
Milestone
[L1] 1 - Read-onl...

Comments

@fmoletta
Copy link
Contributor

fmoletta commented Aug 15, 2024 •
edited by avilagaston9
Loading

  • get-block-by-empty-hash
  • get-block-by-hash
  • get-block-by-notfound-hash
@fmoletta fmoletta mentioned this issue Aug 15, 2024
Open
29 tasks
@mpaulucci mpaulucci added this to the 1 - Read-only RPC Node milestone Aug 16, 2024
@mpaulucci mpaulucci added the ef-tests Hive tests, execution-spec-tests label Aug 16, 2024
@avilagaston9 avilagaston9 self-assigned this Aug 22, 2024
@avilagaston9 avilagaston9 mentioned this issue Aug 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 26, 2024
@avilagaston9
fix: ethBlockByHash endpoint (#304)
60a89f0 
**Motivation**

We are currently not matching the expected response from Hive on the
`eth_getBlockByHash` endpoint.

**Description**

- Moves `BlockSerializable` to the RPC module.
- Renames `BlockSerializable` to `RpcBlock`.
- Creates `FullBlockBody` which holds `RpcTransaction` instead of
`Transaction` to match the Hive expected output.
- Adds logic to calculate `TotalDifficulty` of blocks.

**Observations**

#307 was created to remove `TotalDifficulty` calculation logic added by
this PR. This is because this field it is not being used since the
merge, but it is still required to pass Hive tests.

Closes #269
mpaulucci pushed a commit to mpaulucci/lambda_ethereum_rust that referenced this issue Oct 16, 2024
@avilagaston9
fix: ethBlockByHash endpoint (lambdaclass#304)
0c2568c 
**Motivation**

We are currently not matching the expected response from Hive on the
`eth_getBlockByHash` endpoint.

**Description**

- Moves `BlockSerializable` to the RPC module.
- Renames `BlockSerializable` to `RpcBlock`.
- Creates `FullBlockBody` which holds `RpcTransaction` instead of
`Transaction` to match the Hive expected output.
- Adds logic to calculate `TotalDifficulty` of blocks.

**Observations**

lambdaclass#307 was created to remove `TotalDifficulty` calculation logic added by
this PR. This is because this field it is not being used since the
merge, but it is still required to pass Hive tests.

Closes lambdaclass#269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avilagaston9 avilagaston9

Labels
ef-tests Hive tests, execution-spec-tests
Projects
ethrex_l1
Status: Done
Milestone
[L1] 1 - Read-only RPC Node
Development

Successfully merging a pull request may close this issue.

fix: ethBlockByHash endpoint lambdaclass/ethrex
3 participants
@mpaulucci @avilagaston9 @fmoletta