fix: ethBlockByHash endpoint
#304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avilagaston9
changed the title
ethBlockByHash endpoint
mpaulucci
reviewed
Aug 23, 2024
| @@ -430,67 +428,14 @@ fn calc_excess_blob_gas(parent_header: &BlockHeader) -> u64 { | |||
| } | |||
| } | |||
|
|
|||
| #[allow(unused)] | |||
mpaulucci
approved these changes
Aug 26, 2024
mpaulucci
pushed a commit
to mpaulucci/lambda_ethereum_rust
that referenced
this pull request
Oct 16, 2024
**Motivation** We are currently not matching the expected response from Hive on the `eth_getBlockByHash` endpoint. **Description** - Moves `BlockSerializable` to the RPC module. - Renames `BlockSerializable` to `RpcBlock`. - Creates `FullBlockBody` which holds `RpcTransaction` instead of `Transaction` to match the Hive expected output. - Adds logic to calculate `TotalDifficulty` of blocks. **Observations** lambdaclass#307 was created to remove `TotalDifficulty` calculation logic added by this PR. This is because this field it is not being used since the merge, but it is still required to pass Hive tests. Closes lambdaclass#269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are currently not matching the expected response from Hive on the
eth_getBlockByHashendpoint.Description
BlockSerializableto the RPC module.BlockSerializabletoRpcBlock.FullBlockBodywhich holdsRpcTransactioninstead ofTransactionto match the Hive expected output.TotalDifficultyof blocks.Observations
#307 was created to remove
TotalDifficultycalculation logic added by this PR. This is because this field it is not being used since the merge, but it is still required to pass Hive tests.Closes #269