Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with L1 #814

Open
lazcanoluca opened this issue Oct 10, 2024 · 0 comments
Open

Integration with L1 #814

lazcanoluca opened this issue Oct 10, 2024 · 0 comments
Assignees
Labels
levm Lambda EVM implementation

Comments

@lazcanoluca
Copy link
Contributor

No description provided.

@lazcanoluca lazcanoluca added the levm Lambda EVM implementation label Oct 10, 2024
@lazcanoluca lazcanoluca changed the title LEVM: Probar integración con L1 LEVM: Test integration with L1 Oct 10, 2024
@lazcanoluca lazcanoluca self-assigned this Oct 10, 2024
@juanimedone juanimedone changed the title LEVM: Test integration with L1 Integration with L1 Oct 16, 2024
@juanimedone juanimedone linked a pull request Oct 18, 2024 that will close this issue
@juanimedone juanimedone linked a pull request Oct 29, 2024 that will close this issue
github-merge-queue bot pushed a commit that referenced this issue Oct 31, 2024
**Motivation**

<!-- Why does this pull request exist? What are its goals? -->
We currently have an in-memory database that should soon be replaced by
the node's in-disk database. For that purpose we want to allow us to
switch between both kinds of databases. The need to implement this PR's
features and refactor the `Db` arose while working on #904.

**Description**

<!-- A clear and concise general description of the changes this PR
introduces -->
This PR includes:
- Adding a `Cache` to store warm accounts. This removes the need of
having `accessed_accounts` and `accessed_storage_slots` sets in
`Substate` because we know that if they are cached then they are warm.
- Making our `Db` implement the `Database` trait and interact with it
only using methods and not it's attributes, so in the future we can
implement that trait for the actual node's database.
- Fix call opcodes and remove delegate attribute from `CallFrame`.

<!-- Link to issues: Resolves #111, Resolves #222 -->

Part of #814.

---------

Co-authored-by: Juani Medone <juan.medone@lambdaclass.com>
Co-authored-by: maximopalopoli <mpalopoli@fi.uba.ar>
Co-authored-by: Javier Chatruc <jrchatruc@gmail.com>
h3lio5 pushed a commit to h3lio5/lambda_ethereum_rust that referenced this issue Oct 31, 2024
**Motivation**

<!-- Why does this pull request exist? What are its goals? -->
We currently have an in-memory database that should soon be replaced by
the node's in-disk database. For that purpose we want to allow us to
switch between both kinds of databases. The need to implement this PR's
features and refactor the `Db` arose while working on lambdaclass#904.

**Description**

<!-- A clear and concise general description of the changes this PR
introduces -->
This PR includes:
- Adding a `Cache` to store warm accounts. This removes the need of
having `accessed_accounts` and `accessed_storage_slots` sets in
`Substate` because we know that if they are cached then they are warm.
- Making our `Db` implement the `Database` trait and interact with it
only using methods and not it's attributes, so in the future we can
implement that trait for the actual node's database.
- Fix call opcodes and remove delegate attribute from `CallFrame`.

<!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 -->

Part of lambdaclass#814.

---------

Co-authored-by: Juani Medone <juan.medone@lambdaclass.com>
Co-authored-by: maximopalopoli <mpalopoli@fi.uba.ar>
Co-authored-by: Javier Chatruc <jrchatruc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
levm Lambda EVM implementation
Projects
Status: No status
3 participants