feat(levm): implement Cache and refactor Db
#991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JereSalo
changed the title
…reum_rust into levm/refactor/db
…reum_rust into levm/refactor/db
…reum_rust into levm/refactor/db
…reum_rust into levm/refactor/db
juanimedone
changed the title
Cache and refactor Db
jrchatruc
approved these changes
Oct 31, 2024
h3lio5
pushed a commit
to h3lio5/lambda_ethereum_rust
that referenced
this pull request
Oct 31, 2024
**Motivation** <!-- Why does this pull request exist? What are its goals? --> We currently have an in-memory database that should soon be replaced by the node's in-disk database. For that purpose we want to allow us to switch between both kinds of databases. The need to implement this PR's features and refactor the `Db` arose while working on lambdaclass#904. **Description** <!-- A clear and concise general description of the changes this PR introduces --> This PR includes: - Adding a `Cache` to store warm accounts. This removes the need of having `accessed_accounts` and `accessed_storage_slots` sets in `Substate` because we know that if they are cached then they are warm. - Making our `Db` implement the `Database` trait and interact with it only using methods and not it's attributes, so in the future we can implement that trait for the actual node's database. - Fix call opcodes and remove delegate attribute from `CallFrame`. <!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 --> Part of lambdaclass#814. --------- Co-authored-by: Juani Medone <juan.medone@lambdaclass.com> Co-authored-by: maximopalopoli <mpalopoli@fi.uba.ar> Co-authored-by: Javier Chatruc <jrchatruc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We currently have an in-memory database that should soon be replaced by the node's in-disk database. For that purpose we want to allow us to switch between both kinds of databases. The need to implement this PR's features and refactor the
Dbarose while working on #904.Description
This PR includes:
Cacheto store warm accounts. This removes the need of havingaccessed_accountsandaccessed_storage_slotssets inSubstatebecause we know that if they are cached then they are warm.Dbimplement theDatabasetrait and interact with it only using methods and not it's attributes, so in the future we can implement that trait for the actual node's database.CallFrame.Part of #814.