Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EIP2930 transactions #138

Merged
merged 2 commits into from
Jul 11, 2024
Merged

feat: add EIP2930 transactions #138

merged 2 commits into from
Jul 11, 2024

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Jul 10, 2024

Motivation

Add support for EIP2930 transaction

Description

Implements EIP2930Transaction + required methods & traits

Closes #24 (evm already performs validations before executing so adding the transaction itself will sufice)

@fmoletta fmoletta changed the title feat: Add EIP2930 transactions feat: add EIP2930 transactions Jul 10, 2024
@fmoletta fmoletta marked this pull request as ready for review July 10, 2024 20:55
@fmoletta fmoletta requested a review from a team as a code owner July 10, 2024 20:55
Copy link
Collaborator

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MegaRedHand MegaRedHand merged commit b906eb0 into main Jul 11, 2024
3 of 6 checks passed
@MegaRedHand MegaRedHand deleted the eip2930-tx branch July 11, 2024 14:09
fmoletta added a commit that referenced this pull request Jul 12, 2024
This PR is based on #138 (as they modify the same code), please merge it
first

**Motivation**

Add support for EIP4844 transactions

<!-- Why does this pull request exist? What are its goals? -->

**Description**

Add `EIP4844` transactions + needed trait and methods and integrate it
into existing transaction-related code

<!-- A clear and concise general description of the changes this PR
introduces -->

<!-- Link to issues: Resolves #111, Resolves #222 -->

Closes #26 (evm already performs validations before executing so adding
the transaction itself will sufice)
mpaulucci pushed a commit to mpaulucci/lambda_ethereum_rust that referenced this pull request Oct 16, 2024
**Motivation**

Add support for EIP2930 transaction

**Description**


Implements EIP2930Transaction  + required methods & traits
<!-- A clear and concise general description of the changes this PR
introduces -->

<!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 -->

Closes None, but will enable lambdaclass#135 to also close lambdaclass#24
mpaulucci pushed a commit to mpaulucci/lambda_ethereum_rust that referenced this pull request Oct 16, 2024
This PR is based on lambdaclass#138 (as they modify the same code), please merge it
first

**Motivation**

Add support for EIP4844 transactions

<!-- Why does this pull request exist? What are its goals? -->

**Description**

Add `EIP4844` transactions + needed trait and methods and integrate it
into existing transaction-related code

<!-- A clear and concise general description of the changes this PR
introduces -->

<!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 -->

Closes lambdaclass#26 (evm already performs validations before executing so adding
the transaction itself will sufice)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for validating EIP-2930 transactions
2 participants