Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Dialect: German (Python) #11

Closed
2 tasks done
madiedgar opened this issue Oct 4, 2019 · 15 comments
Closed
2 tasks done

Add New Dialect: German (Python) #11

madiedgar opened this issue Oct 4, 2019 · 15 comments

Comments

@madiedgar
Copy link
Member

madiedgar commented Oct 4, 2019

Adding German to the Legesher Translations for Python

Version 1 of Legesher only includes translations for the Python programming language. In order to add this language to the project, complete the steps detailed in the translation guide

To complete this issue:

  • Create german dialect .yml file
  • Enter translation for at least the Python keywords

Reviewers Needed

In order to add the translations into our database to use, the translations will need to be approved and accepted by 3 additional native / fluent speakers. If you would like to be one of the reviewers for this language, please mention in this issue! 😄

@madiedgar
Copy link
Member Author

hey @LoLei 👋, have a fun opportunity for you!

@LoLei
Copy link
Member

LoLei commented Oct 4, 2019

Thanks for the notification, I'll keep this in mind, can't promise I can do it quickly though.

@madiedgar
Copy link
Member Author

No worries! These translation issues will take a little more time, even if its just the Python keywords! Trying to have more people tackle this with you, so you don't get overwhelmed with the translation. 😄

@ZeroOne010101
Copy link

ZeroOne010101 commented Oct 5, 2019

Hi! I am a Native speaker from Germany and am looking for things to do for Hacktoberfest.

Just to clarify up front:
I know nothing about this Project.
I am self taught so i may not know the correct technical terms.
I am currently very stressed with exams and life in general so i will not be able to work on this on a regular basis.

Now that that's out of the way: Hi, im zero, im 18 years old, live in Germany and want to work with you!

@madiedgar
Copy link
Member Author

Hi @ZeroOne010101 👋 We're happy to have you here! My hope is that this project isn't another stress to your day, but a form of release and something that brings joy! ✨

All of the legesher repositories work together in some way. These translations are critical in allowing developers to code in their native language. When version 1 is released, developers will have the ability to take this python function:

def helloWorld():
  print("Hello World!")

and have every aspect of it in their native language - not just the self-named variables, but the keywords as well!

Our biggest priority this hacktoberfest is translating the python programming language keywords, so we can release our first version of python with as many spoken languages as possible.

Hope this makes sense 😄 If you have any questions, please feel free to reach out! 👍

@ZeroOne010101
Copy link

ZeroOne010101 commented Oct 5, 2019

@madiedgar Just one question for now: Should i work towards one big PR , a couple small ones or in a fork and then transfer the final product via PR?

@ZeroOne010101
Copy link

Im done with the first pass, some things sound really weird, while others dont really have a translation. should i just keep those in english?

@madiedgar
Copy link
Member Author

@ZeroOne010101 great question - what if I create a german-translation fork on the repo and you can add incremental pull requests to that specific branch. That way if more people want to add to the translation, they can help on that branch. When the translations get approved, merging the branch into master would mean it's ready to be used across the entire Legseher project! How does that sound? 😃

Hmm 🤔, this is what I expected but was curious as to what to do about them. Let's keep them English for now, adding any commentary that would be useful in comments.

@ZeroOne010101
Copy link

ZeroOne010101 commented Oct 5, 2019

@madiedgar sounds good! im ready to PR whenever you are!

@madiedgar
Copy link
Member Author

@ZeroOne010101 awesome!! I made the german-translation branch, so feel free to add it there! 😄

@ZeroOne010101
Copy link

@madiedgar added #12

@madiedgar
Copy link
Member Author

Great job @ZeroOne010101, I'm closing this issue as this was resolved in #12 & #15. I'll open up a translation review issue so we can merge in this wonderful work for people to use 👍

@JohannaHillebrand
Copy link

I reviewed the translation and there are some inconsistencies. In German nouns should have a an uppercase initial letter. Sometimes this is done, sometimes not.
Also in German you often need to use two words, where only one suffices in English.
Sometimes those two words are just put together and sometimes CamelCase is used.
If you guys tell me, what would be preferred, I could change that, so it is more consistent.

@madiedgar
Copy link
Member Author

Such interesting facts about the German language! Thank you so much for sharing this! Definitely would be something to discuss further 😄

madiedgar pushed a commit that referenced this issue Oct 28, 2019
* review german translation

* add german-translation for C-Keywords

* add German translation for Java-Keywords
🎉 thank you @JohannaHillebrand for your contribution!
@lock
Copy link

lock bot commented Apr 25, 2020

⚠️This issue has been automatically locked 🔒since there has not been any recent activity after it was closed. Please open a new 🆕issue for related bugs and mention this issue. Thanks! 👍

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
@madiedgar madiedgar added this to the German Language Translation milestone Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.