Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reviewed German Python translation #105

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Reviewed German Python translation #105

merged 2 commits into from
Oct 30, 2019

Conversation

merelyAnna
Copy link

Review for #11 as described in #43

@merelyAnna
Copy link
Author

I'll have a look at the conflicts and will resolve them tomorrow after work.

madiedgar
madiedgar approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@madiedgar madiedgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 👍

@madiedgar
Copy link
Member

Thank you so much @merelyAnna! Don't worry about the linting errors, but you would know better than me about the merge conflicts in the file. Take your time on those 👍

@madiedgar madiedgar added this to the Hacktoberfest milestone Oct 28, 2019
@merelyAnna
Copy link
Author

@madiedgar I've fixed the conflicts, but I don't quite understand why the checks fail, so I don't know how to go about fixing them. Could you help me out with that?

madiedgar
madiedgar approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@madiedgar madiedgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BEAUTIFUL

@madiedgar madiedgar merged commit a09494c into legesher:german-translation Oct 30, 2019
@merelyAnna
Copy link
Author

😊Happy to help.
Feel free to tag me if there is more that needs to be translated to German or German that needs to be reviewed.

@merelyAnna merelyAnna deleted the issue-43-german-review branch October 30, 2019 18:35
@madiedgar
Copy link
Member

madiedgar commented Oct 30, 2019 •
edited
Loading

Forgive me 🙊You were so active before this PR, I thought I already sent you this!

Congrats on merging your first pull request! 🎉🎉🎉 ❤️ THANK YOU THANK YOU THANK YOU ❤️ We'd love to celebrate you and your contribution to the community. Let us say "Thank You" again, by sending you a special gift only given to those who have chosen to give back.
We couldn't thank you enough for your contribution. We hope you continue sharing your gifts and knowledge with not just us, but with the world around you.😍

@madiedgar madiedgar mentioned this pull request Oct 31, 2019
Closed
14 tasks
@madiedgar madiedgar mentioned this pull request Dec 30, 2020
Open
madiedgar pushed a commit that referenced this pull request Oct 2, 2022
@merelyAnna @madiedgar
Reviewed German Python translation (#105)
fe683e8 
🎉 thank you @merelyAnna for your contribution!
madiedgar pushed a commit that referenced this pull request Sep 18, 2023
@merelyAnna @madiedgar
Reviewed German Python translation (#105)
ae5f7f9 
🎉 thank you @merelyAnna for your contribution!
madiedgar pushed a commit that referenced this pull request Sep 18, 2023
@merelyAnna @madiedgar
Reviewed German Python translation (#105)
a70c102 
🎉 thank you @merelyAnna for your contribution!
@madiedgar madiedgar added this to the German Language Translation milestone Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madiedgar madiedgar madiedgar approved these changes

Assignees

@merelyAnna merelyAnna

Labels
Dialect: German 🌍 Opportunity: Translation
Projects
None yet
Milestone
German Language Translation
Development

Successfully merging this pull request may close these issues.
2 participants
@merelyAnna @madiedgar