Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Dialect: German (Python) #43

Closed
13 of 14 tasks
madiedgar opened this issue Oct 17, 2019 · 10 comments
Closed
13 of 14 tasks

Review Dialect: German (Python) #43

madiedgar opened this issue Oct 17, 2019 · 10 comments

Comments

@madiedgar
Copy link
Member

madiedgar commented Oct 17, 2019

Review German Language Translations for the Python Programming Language

In order to review this language to the project, complete the steps detailed in the translation guide (from Step # 6 onward). We are primarily working developing Legesher for the Python programming language. In the future we hope to add more programming languages.

Reviewing a translation is extremely important as we want to best understand the culture and context behind the words we select as keywords for the programming languages. The more perspectives the better! 👀Please take your time in being thorough with these translations. Think back when you were learning how to program and how context of words help you bridge together meaning and functionality.

⚠️ Note: this issue is to review the Python keywords and builtin functions only. Any additional translation reviews are encouraged, but not necessary.

To complete this issue:

  • Update any content in this issue from German to the name of the language. (Romanian, Arabic, Welsh etc.)
  • Title this issue "Review Language: German (Python)"
  • Update the Python section of the German's locale/__.yml file (files are named using the language abbreviation) by adding comments as followed:
    • Leave a after a translation if you agree that's the right word to give context to the keyword
    • Leave a after a translation if you think there may be a better translation / form of the translation
    • Leave a 🤔 after a word that you're not sure if there is a translation
  • Merge changes into branch titled german-translation on this repo. Please reference this issue in the pull request.

Reviewers Needed

In order to add the translations for official use across Legesher, the translations will need to be approved and accepted by 5 additional native / fluent speakers. If you would like to be one of the reviewers for this language, please mention in this issue! 😄 Also feel free to loop in a friend that might be able to help with the translations! Please refer to the translation guide for the next step in the review process.

Review Status:

@madiedgar madiedgar added this to the Hacktoberfest milestone Oct 17, 2019
This was referenced Oct 21, 2019
madiedgar pushed a commit that referenced this issue Oct 24, 2019
* review german translation

* Reviewed the German translation of Python (#66)

🎉 thank you @nausicaea for your contribution!

* review german translation
🎉 thank you @otherpaco for your contribution!
@JohannaHillebrand
Copy link

Do you still need help with reviewing the translations? I'm a native-german-speaker and would like to contribute :)

@madiedgar
Copy link
Member Author

madiedgar commented Oct 27, 2019

Yes @JohannaHillebrand! Still looking for reviewers for this translation!

@merelyAnna
Copy link

I am also a native-german speaker and am happy to help out if more help is needed :)

@diana48
Copy link

diana48 commented Oct 30, 2019

Do you still need someone to review? I'm also a native German speaker and would love to help out!

@madiedgar
Copy link
Member Author

Yes @diana48, that would be amazing!! 👍

@alxnull
Copy link
Member

alxnull commented Oct 3, 2020

Just found this promising looking project. Seems like German already reached the required amount of reviewers, or would you still accept another review? :)

@madiedgar
Copy link
Member Author

Hey @alxnull 👋 Thanks for your interest! Would love to finalize the python translation and would really appreciate your help with that. 👍

@alxnull
Copy link
Member

alxnull commented Oct 4, 2020

Hey @madiedgar,

Just to clear things up for me 😅: Should I do another review or does "finalizing the Python translation" mean step 8 of the translation guide? How would I approach this? Open a new PR to master with a final version of the German translation, taking all reviewer comments into account and highlighting translations that are still controversial/ unclear for further discussion?

@madiedgar
Copy link
Member Author

Great question @alxnull 👍 if you could be the last reviewer for python that would be great. After your PR is merged, I'll create another issue for officially finalizing the python translation where all of the previous contributors will be looped in.

@madiedgar
Copy link
Member Author

Closing this issue, as we are now preparing for the official translation in #184 🎉

madiedgar pushed a commit that referenced this issue Oct 2, 2022
* review german translation

* Reviewed the German translation of Python (#66)

🎉 thank you @nausicaea for your contribution!

* review german translation
🎉 thank you @otherpaco for your contribution!
madiedgar pushed a commit that referenced this issue Sep 18, 2023
* review german translation

* Reviewed the German translation of Python (#66)

🎉 thank you @nausicaea for your contribution!

* review german translation
🎉 thank you @otherpaco for your contribution!
madiedgar pushed a commit that referenced this issue Sep 18, 2023
* review german translation

* Reviewed the German translation of Python (#66)

🎉 thank you @nausicaea for your contribution!

* review german translation
🎉 thank you @otherpaco for your contribution!
@madiedgar madiedgar added this to the German Language Translation milestone Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment