Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#43 reviewed translations #64

Closed

Conversation

twille00
Copy link

I reviewed the python-translations

✓ - good translation
? - not good translation

@twille00
Copy link
Author

Ascii-Symbols may lead to errors... can you give an alternate to me or replace ✓ with any symbol you like.

@madiedgar
Copy link
Member

Thank you so much @twille00 for your translation reviews!! This is great 👏 Could you help me a bit as there are a couple of people that translated German at the same time? (great problem to have!)

  • Update the german-translation with the master branch
  • Use the review conventions described in Review Dialect: German (Python) #43 as you integrate your changes in the updated de.yml file
  • Move the de.yml file inside the locale/ folder

Copy link
Member

@madiedgar madiedgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 👍, Could you resolve the conflicts by following the instructions in the comment? Would love to add in your contribution!

@madiedgar
Copy link
Member

Hey @twille00, let me know if you need any help with updating this! 👍 thanks so much for your work thus far!

@madiedgar
Copy link
Member

Thank you so much @twille00 for your contribution! I added your review in this commit and added you as a co-author 👍 Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants