Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#43 review german translation #65

Merged
merged 4 commits into from
Oct 24, 2019
Merged

#43 review german translation #65

merged 4 commits into from
Oct 24, 2019

Conversation

otherpaco
Copy link

No description provided.

🎉 thank you @nausicaea for your contribution!
@madiedgar
Copy link
Member

Thank you so much @otherpaco for your translation reviews!! This is great 👏 Could you help me a bit as there are a couple of people that translated German at the same time? (great problem to have!)

  • Update the german-translation with the master branch
  • Use the review conventions described in Review Dialect: German (Python) #43 as you integrate your changes in the updated de.yml file
  • Move the de.yml file inside the locale/ folder

I asked #64 to do the same, so keep that in mind when you're submitting changes.

Copy link
Member

@madiedgar madiedgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 👍, Could you resolve the conflicts by following the instructions in the comment? Would love to add in your contribution!

@madiedgar madiedgar mentioned this pull request Oct 23, 2019
14 tasks
@otherpaco
Copy link
Author

@madiedgar I am not sure what you mean by "update". Here is what I did. I updated the de.yml file with comments of both pull requests #64 #65 in the german-translation branch.

Copy link
Member

@madiedgar madiedgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 👍 Thank you so much 👏

@madiedgar madiedgar merged commit ad4a0c0 into legesher:german-translation Oct 24, 2019
@madiedgar
Copy link
Member

Congrats on merging your first pull request @otherpaco ! 🎉🎉🎉 ❤️ THANK YOU THANK YOU THANK YOU ❤️ We'd love to celebrate you and your contribution to the community. Let us say "Thank You" again, by sending you a special gift!

We couldn't thank you enough for your contribution. We hope you continue sharing your gifts and knowledge with not just us, but with the world around you.😍

madiedgar pushed a commit that referenced this pull request Oct 2, 2022
* review german translation

* Reviewed the German translation of Python (#66)

🎉 thank you @nausicaea for your contribution!

* review german translation
🎉 thank you @otherpaco for your contribution!
madiedgar pushed a commit that referenced this pull request Sep 18, 2023
* review german translation

* Reviewed the German translation of Python (#66)

🎉 thank you @nausicaea for your contribution!

* review german translation
🎉 thank you @otherpaco for your contribution!
madiedgar pushed a commit that referenced this pull request Sep 18, 2023
* review german translation

* Reviewed the German translation of Python (#66)

🎉 thank you @nausicaea for your contribution!

* review german translation
🎉 thank you @otherpaco for your contribution!
@madiedgar madiedgar added this to the German Language Translation milestone Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants