Skip to content

Conversation

yanxi0830
Copy link
Contributor

@yanxi0830 yanxi0830 commented Feb 20, 2025

What does this PR do?

  • Fully deprecate eval/tasks

Closes #1088

NOTE: this will be a breaking change. We have introduced the new API in 0.1.3 .

Notebook has been updated to use the new endpoints.

Test Plan

pytest -v -s --nbval-lax ./docs/notebooks/Llama_Stack_Benchmark_Evals.ipynb 
image

cc @SLR722 for awareness

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 20, 2025
@yanxi0830 yanxi0830 marked this pull request as ready for review February 20, 2025 21:06
@yanxi0830 yanxi0830 added this to the v0.1.4 milestone Feb 20, 2025
@yanxi0830 yanxi0830 changed the title chore!: deprecate eval/taks chore!: deprecate eval/tasks Feb 20, 2025
@yanxi0830 yanxi0830 merged commit ea1faae into main Feb 20, 2025
4 checks passed
@yanxi0830 yanxi0830 deleted the deprecate_eval_task branch February 20, 2025 22:06
yanxi0830 added a commit to llamastack/llama-stack-client-python that referenced this pull request Feb 20, 2025
…#150)

# What does this PR do?
- See llamastack/llama-stack#1186

## Test Plan
- Test in llamastack/llama-stack#1186

[//]: # (## Documentation)
[//]: # (- [ ] Added a Changelog entry if the change is significant)
yanxi0830 added a commit that referenced this pull request Mar 4, 2025
# What does this PR do?

- This was missed from previous deprecation:
#1186
- Part of #1396

[//]: # (If resolving an issue, uncomment and update the line below)
[//]: # (Closes #[issue-number])

## Test Plan
```
pytest -v -s --nbval-lax ./llama-stack/docs/notebooks/Llama_Stack_Benchmark_Evals.ipynb 
```

[//]: # (## Documentation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fully deprecate /eval-tasks endpoint

3 participants