chore: rename task_config to benchmark_config #1397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanxi0830
requested review from
ashwinb,
dineshyv,
dltn,
ehhuang,
hardikjshah,
raghotham,
sixianyi0721,
terrytangyuan and
vladimirivic
as code owners
facebook-github-bot
added
the
CLA Signed
yanxi0830
commented
Mar 4, 2025
| input_rows=rows.rows, | ||
| scoring_functions=scoring_functions, | ||
| task_config=AppBenchmarkConfig( | ||
| benchmark_config=AppBenchmarkConfig( |
There was a problem hiding this comment.
This file is outdated, will be cleaned up in following PR.
raghotham
approved these changes
Mar 4, 2025
yanxi0830
added a commit
to llamastack/llama-stack-client-python
that referenced
this pull request
Mar 4, 2025
…nchmark_config (Sync updates from stainless branch: yanxi0830/dev) (#176) # What does this PR do? - Adapt to API changes in llamastack/llama-stack#1397 and llamastack/llama-stack#1377 [//]: # (If resolving an issue, uncomment and update the line below) [//]: # (Closes #[issue-number]) ## Test Plan ``` LLAMA_STACK_BASE_URL=http://localhost:8321 pytest -v tests/integration/agents/test_agents.py--inference-model "meta-llama/Llama-3.3-70B-Instruct" --record-responses ``` ``` pytest -v -s --nbval-lax ./docs/notebooks/Llama_Stack_Benchmark_Evals.ipynb ``` [//]: # (## Documentation) [//]: # (- [ ] Added a Changelog entry if the change is significant)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test Plan