[CIR][CIRGen] Implement support for printf builtin #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a function to emit the printf builtin declaration, alongside some updates to generate calls for said builtin. [ghstack-poisoned]
This was referenced Jun 5, 2023
sitio-couto
commented
Jun 5, 2023
Adds a function to emit the printf builtin declaration, alongside some updates to generate calls for said builtin. [ghstack-poisoned]
This was referenced Jun 6, 2023
bcardosolopes
requested changes
Jun 6, 2023
Member
|
Also overall seems like you stack a bunch of unrelated changes, it's probably better to use individual PRs, without the stack feature if commits are not related (so we can merge things that look good sooner and have no deps) |
Adds a function to emit the printf builtin declaration, alongside some updates to generate calls for said builtin. [ghstack-poisoned]
Adds a function to emit the printf builtin declaration, alongside some updates to generate calls for said builtin. [ghstack-poisoned]
pysuxing
pushed a commit
to pysuxing/llvm-project
that referenced
this pull request
Jul 17, 2024
Adds a function to emit the printf builtin declaration, alongside some updates to generate calls for said builtin. ghstack-source-id: fe5dad92dca9f33f1c089b5aaac6c5a3b39993f6 Pull Request resolved: llvm/clangir#100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Adds a function to emit the printf builtin declaration, alongside
some updates to generate calls for said builtin.