Skip to content

[CIR][Lowering] Add support for signed comparisons #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sitio-couto merged 4 commits into from
Jun 6, 2023
Merged

[CIR][Lowering] Add support for signed comparisons #106

sitio-couto merged 4 commits into from
Jun 6, 2023

Conversation

@sitio-couto
Copy link
Collaborator

@sitio-couto sitio-couto commented Jun 6, 2023 •
edited
Loading

@sitio-couto
[CIR][Lowering] Add support for signed comparisons
364a487 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

[ghstack-poisoned]
This was referenced Jun 5, 2023
Merged
Merged
Merged
Merged
Merged
sitio-couto added a commit that referenced this pull request Jun 6, 2023
@sitio-couto
[CIR][Lowering] Add support for signed comparisons
0a44cce 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: bd3c20f
Pull Request resolved: #106
bcardosolopes
bcardosolopes approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sitio-couto
Update on "[CIR][Lowering] Add support for signed comparisons"
75e0913 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

[ghstack-poisoned]
sitio-couto added a commit that referenced this pull request Jun 6, 2023
@sitio-couto
[CIR][Lowering] Add support for signed comparisons
a37fed4 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: 613c57a
Pull Request resolved: #106
@sitio-couto
Update on "[CIR][Lowering] Add support for signed comparisons"
a8cc82c 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

[ghstack-poisoned]
sitio-couto added a commit that referenced this pull request Jun 6, 2023
@sitio-couto
[CIR][Lowering] Add support for signed comparisons
d9495f4 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: 613c57a
Pull Request resolved: #106
@sitio-couto
Update on "[CIR][Lowering] Add support for signed comparisons"
bd5bd23 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

[ghstack-poisoned]
sitio-couto added a commit that referenced this pull request Jun 6, 2023
@sitio-couto
[CIR][Lowering] Add support for signed comparisons
aaeeb74 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: e470931
Pull Request resolved: #106
@sitio-couto sitio-couto merged commit bd5bd23 into gh/sitio-couto/40/base Jun 6, 2023
sitio-couto added a commit that referenced this pull request Jun 6, 2023
@sitio-couto
[CIR][Lowering] Add support for signed comparisons
5a81120 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: e470931
Pull Request resolved: #106
@sitio-couto sitio-couto deleted the gh/sitio-couto/40/head branch June 6, 2023 23:27
lanza pushed a commit that referenced this pull request Jul 6, 2023
@sitio-couto @lanza
[CIR][Lowering] Add support for signed comparisons
df49b9b 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: e470931
Pull Request resolved: #106
lanza pushed a commit that referenced this pull request Oct 27, 2023
@sitio-couto @lanza
[CIR][Lowering] Add support for signed comparisons
ca63276 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: e470931
Pull Request resolved: #106
lanza pushed a commit that referenced this pull request Dec 20, 2023
@sitio-couto @lanza
[CIR][Lowering] Add support for signed comparisons
7e09f50 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: e470931
Pull Request resolved: #106
lanza pushed a commit that referenced this pull request Jan 29, 2024
@sitio-couto @lanza
[CIR][Lowering] Add support for signed comparisons
523e050 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: e470931
Pull Request resolved: #106
lanza pushed a commit that referenced this pull request Mar 23, 2024
@sitio-couto @lanza
[CIR][Lowering] Add support for signed comparisons
b2443f3 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: e470931
Pull Request resolved: #106
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@sitio-couto @lanza
[CIR][Lowering] Add support for signed comparisons
14883a3 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: e470931
Pull Request resolved: llvm#106
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][Lowering] Add support for signed comparisons
1451824 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: e470931
Pull Request resolved: #106
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][Lowering] Add support for signed comparisons
6a68d85 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: e470931
Pull Request resolved: #106
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][Lowering] Add support for signed comparisons
13640d3 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: e470931
Pull Request resolved: llvm#106
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][Lowering] Add support for signed comparisons
e5b0f2c 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: e470931
Pull Request resolved: #106
pysuxing pushed a commit to pysuxing/llvm-project that referenced this pull request Jul 17, 2024
@sitio-couto @lanza
[CIR][Lowering] Add support for signed comparisons
214f3fb 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: e4709315db1a39853fe978ef9771ab727ad9f9d7
Pull Request resolved: llvm/clangir#106
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@sitio-couto @lanza
[CIR][Lowering] Add support for signed comparisons
44d7349 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: e470931
Pull Request resolved: llvm#106
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
@sitio-couto @lanza
[CIR][Lowering] Add support for signed comparisons
906cc37 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: e470931
Pull Request resolved: llvm#106
xlauko pushed a commit to xlauko/clangir that referenced this pull request Feb 11, 2025
@sitio-couto @xlauko
[CIR][Lowering] Add support for signed comparisons
418f897 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: e470931
Pull Request resolved: llvm#106
lanza pushed a commit that referenced this pull request Mar 18, 2025
@sitio-couto @lanza
[CIR][Lowering] Add support for signed comparisons
2a4d598 
Updates CIR's CmpOp lowering to use CIR's custom cir::IntType, allowing
it to handle signed comparisons.

ghstack-source-id: e470931
Pull Request resolved: #106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@lanza lanza Awaiting requested review from lanza

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sitio-couto @bcardosolopes