[CIR][Lowering] Refactor CmpOp lowering #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves code reusability and readability when lowering CIR's CmpOp to some LLVM comparison op. [ghstack-poisoned]
This was referenced Jun 5, 2023
sitio-couto
requested review from
bcardosolopes and
lanza
and removed request for
lanza
bcardosolopes
approved these changes
Jun 6, 2023
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
LGTM with minor change: please append "[NFC]" to the title!
Improves code reusability and readability when lowering CIR's CmpOp to some LLVM comparison op. [ghstack-poisoned]
Improves code reusability and readability when lowering CIR's CmpOp to some LLVM comparison op. [ghstack-poisoned]
Improves code reusability and readability when lowering CIR's CmpOp to some LLVM comparison op. [ghstack-poisoned]
pysuxing
pushed a commit
to pysuxing/llvm-project
that referenced
this pull request
Jul 17, 2024
Improves code reusability and readability when lowering CIR's CmpOp to some LLVM comparison op. ghstack-source-id: 4975d9ff70d838069b4ce01f125be6178df18fb2 Pull Request resolved: llvm/clangir#105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Improves code reusability and readability when lowering CIR's CmpOp to
some LLVM comparison op.