[CIR] Refactor StructType printing/parsing #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change simplifies the StructType printing/parsing methods. It also updates the representations to group members between braces and to remove commas between type attributes (e.g. id, packed, etc.). [ghstack-poisoned]
This was referenced Aug 11, 2023
bcardosolopes
approved these changes
Aug 14, 2023
This change simplifies the StructType printing/parsing methods. It also updates the representations to group members between braces and to remove commas between type attributes (e.g. id, packed, etc.). [ghstack-poisoned]
This change simplifies the StructType printing/parsing methods. It also updates the representations to group members between braces and to remove commas between type attributes (e.g. id, packed, etc.). [ghstack-poisoned]
This change simplifies the StructType printing/parsing methods. It also updates the representations to group members between braces and to remove commas between type attributes (e.g. id, packed, etc.). [ghstack-poisoned]
pysuxing
pushed a commit
to pysuxing/llvm-project
that referenced
this pull request
Jul 17, 2024
This change simplifies the StructType printing/parsing methods. It also updates the representations to group members between braces and to remove commas between type attributes (e.g. id, packed, etc.). ghstack-source-id: 094d5064f827efe8963855ab8ffd04f4ad1cfb2b Pull Request resolved: llvm/clangir#226
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This change simplifies the StructType printing/parsing methods. It also
updates the representations to group members between braces and to
remove commas between type attributes (e.g. id, packed, etc.).