New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR] Add record kind enum in StructType #227

Merged

sitio-couto merged 4 commits into gh/sitio-couto/47/base from gh/sitio-couto/47/head

Aug 28, 2023

Collaborator

sitio-couto commented Aug 11, 2023 •

edited

Loading

Stack from ghstack (oldest at bottom):

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.


          [CIR] Add record kind enum in StructType

2c1d932

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

[ghstack-poisoned]

This was referenced Aug 11, 2023

[CIR][CIRGen][NFC] Refactor struct type building #225

Merged

[CIR] Refactor StructType printing/parsing #226

Merged

[CIR] Refactor StructElementAddr into GetMemberOp #228

Merged

[CIR][CIRGen][Bugfix] Update unions to track all members #229

Merged

[CIR][Lowering] Lower unions #230

Merged

sitio-couto requested review from bcardosolopes and lanza and removed request for bcardosolopes

August 11, 2023 20:09

bcardosolopes requested changes

View reviewed changes

Member

bcardosolopes left a comment

Thanks for working on this!

clang/include/clang/CIR/Dialect/IR/CIRTypes.td Outdated Show resolved Hide resolved

clang/include/clang/CIR/Dialect/IR/CIRTypes.td Outdated Show resolved Hide resolved

clang/include/clang/CIR/Dialect/IR/CIRTypes.td Outdated Show resolved Hide resolved

clang/lib/CIR/CodeGen/CIRGenTypes.cpp Show resolved Hide resolved

clang/lib/CIR/CodeGen/CIRGenTypes.cpp Outdated Show resolved Hide resolved

clang/lib/CIR/CodeGen/CIRGenVTables.cpp Outdated Show resolved Hide resolved

clang/lib/CIR/Dialect/IR/CIRTypes.cpp Outdated Show resolved Hide resolved

clang/test/CIR/CodeGen/agg-init.cpp Outdated Show resolved Hide resolved


          Update on "[CIR] Add record kind enum in StructType"

a00f285

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

[ghstack-poisoned]

Collaborator Author

sitio-couto commented Aug 22, 2023

@bcardosolopes applied

sitio-couto requested a review from bcardosolopes

August 22, 2023 19:54

bcardosolopes approved these changes

View reviewed changes

Member

bcardosolopes left a comment

LGTM with minor nitpick

clang/lib/CIR/CodeGen/CIRRecordLayoutBuilder.cpp Outdated Show resolved Hide resolved

sitio-couto added 2 commits

August 23, 2023 20:30


          Update on "[CIR] Add record kind enum in StructType"

e1db488

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

[ghstack-poisoned]


          Update on "[CIR] Add record kind enum in StructType"

6124fe0

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

[ghstack-poisoned]

sitio-couto merged commit 6124fe0 into gh/sitio-couto/47/base

sitio-couto added a commit that referenced this pull request


          [CIR] Add record kind enum in StructType

525a198

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

ghstack-source-id: a642fe834f12893d555b527af030d1c2a9c9df46
Pull Request resolved: #227

sitio-couto deleted the gh/sitio-couto/47/head branch

August 28, 2023 23:47

lanza pushed a commit that referenced this pull request


          [CIR] Add record kind enum in StructType

086af26

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

ghstack-source-id: a642fe834f12893d555b527af030d1c2a9c9df46
Pull Request resolved: #227

lanza pushed a commit that referenced this pull request


          [CIR] Add record kind enum in StructType

3e0b39d

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

ghstack-source-id: a642fe834f12893d555b527af030d1c2a9c9df46
Pull Request resolved: #227

lanza pushed a commit that referenced this pull request


          [CIR] Add record kind enum in StructType

539fea7

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

ghstack-source-id: a642fe834f12893d555b527af030d1c2a9c9df46
Pull Request resolved: #227

lanza pushed a commit to lanza/llvm-project that referenced this pull request


          [CIR] Add record kind enum in StructType

1eb527e

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

ghstack-source-id: a642fe834f12893d555b527af030d1c2a9c9df46
Pull Request resolved: llvm/clangir#227

lanza pushed a commit that referenced this pull request


          [CIR] Add record kind enum in StructType

7c05fe4

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

ghstack-source-id: a642fe834f12893d555b527af030d1c2a9c9df46
Pull Request resolved: #227

eZWALT pushed a commit to eZWALT/clangir that referenced this pull request


          [CIR] Add record kind enum in StructType

afd820b

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

ghstack-source-id: a642fe834f12893d555b527af030d1c2a9c9df46
Pull Request resolved: llvm#227

lanza pushed a commit that referenced this pull request


          [CIR] Add record kind enum in StructType

22b9c14

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

ghstack-source-id: a642fe834f12893d555b527af030d1c2a9c9df46
Pull Request resolved: #227

lanza pushed a commit that referenced this pull request


          [CIR] Add record kind enum in StructType

4cf3cd7

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

ghstack-source-id: a642fe834f12893d555b527af030d1c2a9c9df46
Pull Request resolved: #227

eZWALT pushed a commit to eZWALT/clangir that referenced this pull request


          [CIR] Add record kind enum in StructType

b78f318

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

ghstack-source-id: a642fe834f12893d555b527af030d1c2a9c9df46
Pull Request resolved: llvm#227

lanza pushed a commit that referenced this pull request


          [CIR] Add record kind enum in StructType

569b000

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

ghstack-source-id: a642fe834f12893d555b527af030d1c2a9c9df46
Pull Request resolved: #227

pysuxing pushed a commit to pysuxing/llvm-project that referenced this pull request


          [CIR] Add record kind enum in StructType

f63f7b6

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

ghstack-source-id: a642fe834f12893d555b527af030d1c2a9c9df46
Pull Request resolved: llvm/clangir#227

Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request


          [CIR] Add record kind enum in StructType

99824a9

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

ghstack-source-id: a642fe834f12893d555b527af030d1c2a9c9df46
Pull Request resolved: llvm#227

keryell pushed a commit to keryell/clangir that referenced this pull request


          [CIR] Add record kind enum in StructType

eae4e6e

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

ghstack-source-id: a642fe834f12893d555b527af030d1c2a9c9df46
Pull Request resolved: llvm#227

lanza pushed a commit that referenced this pull request


          [CIR] Add record kind enum in StructType

4675a63

Serves as a way to identify the kind of record type (union, class,
struct, etc.), which is useful for codegen and lowering.

ghstack-source-id: a642fe834f12893d555b527af030d1c2a9c9df46
Pull Request resolved: #227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet