[CIR][CIRGen][Bugfix] Update unions to track all members #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes #224 [ghstack-poisoned]
This was referenced Aug 11, 2023
bcardosolopes
approved these changes
Aug 15, 2023
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes #224 [ghstack-poisoned]
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes #224 [ghstack-poisoned]
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes #224 [ghstack-poisoned]
sitio-couto
added a commit
that referenced
this pull request
Aug 28, 2023
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes #224 ghstack-source-id: 8a975426d077a66c49f050741d7362da3c102fed Pull Request resolved: #229
lanza
pushed a commit
that referenced
this pull request
Oct 27, 2023
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes #224 ghstack-source-id: 8a975426d077a66c49f050741d7362da3c102fed Pull Request resolved: #229
lanza
pushed a commit
that referenced
this pull request
Dec 20, 2023
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes #224 ghstack-source-id: 8a975426d077a66c49f050741d7362da3c102fed Pull Request resolved: #229
lanza
pushed a commit
that referenced
this pull request
Jan 29, 2024
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes #224 ghstack-source-id: 8a975426d077a66c49f050741d7362da3c102fed Pull Request resolved: #229
lanza
pushed a commit
to lanza/llvm-project
that referenced
this pull request
Feb 8, 2024
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes llvm#224 ghstack-source-id: 8a975426d077a66c49f050741d7362da3c102fed Pull Request resolved: llvm/clangir#229
lanza
pushed a commit
that referenced
this pull request
Mar 23, 2024
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes #224 ghstack-source-id: 8a975426d077a66c49f050741d7362da3c102fed Pull Request resolved: #229
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Mar 24, 2024
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes llvm#224 ghstack-source-id: 8a975426d077a66c49f050741d7362da3c102fed Pull Request resolved: llvm#229
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes #224 ghstack-source-id: 8a975426d077a66c49f050741d7362da3c102fed Pull Request resolved: #229
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes #224 ghstack-source-id: 8a975426d077a66c49f050741d7362da3c102fed Pull Request resolved: #229
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Apr 29, 2024
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes llvm#224 ghstack-source-id: 8a975426d077a66c49f050741d7362da3c102fed Pull Request resolved: llvm#229
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes #224 ghstack-source-id: 8a975426d077a66c49f050741d7362da3c102fed Pull Request resolved: #229
pysuxing
pushed a commit
to pysuxing/llvm-project
that referenced
this pull request
Jul 17, 2024
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes llvm#224 ghstack-source-id: 8a975426d077a66c49f050741d7362da3c102fed Pull Request resolved: llvm/clangir#229
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes llvm#224 ghstack-source-id: 8a975426d077a66c49f050741d7362da3c102fed Pull Request resolved: llvm#229
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes llvm#224 ghstack-source-id: 8a975426d077a66c49f050741d7362da3c102fed Pull Request resolved: llvm#229
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
This diverges from the original codegen by tracking all members of a union, instead of just the largest one. This is necessary to support type-checking at the MLIR level when accessing union members. It also preserves more information about the source code, which might be useful. Fixes #224 ghstack-source-id: 8a975426d077a66c49f050741d7362da3c102fed Pull Request resolved: #229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diverges from the original codegen by tracking all members of a
union, instead of just the largest one. This is necessary to support
type-checking at the MLIR level when accessing union members. It also
preserves more information about the source code, which might be useful.
Fixes #224