Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hmac,dv] Move IDLE check from vseq to scb #25735

Merged
merged 1 commit into from
Jan 6, 2025
Merged

[hmac,dv] Move IDLE check from vseq to scb #25735

merged 1 commit into from
Jan 6, 2025

Conversation

martin-velay
Copy link
Contributor

@martin-velay martin-velay commented Dec 20, 2024 •
edited
Loading

@martin-velay martin-velay marked this pull request as ready for review December 20, 2024 16:26
@martin-velay martin-velay requested a review from a team as a code owner December 20, 2024 16:26
@martin-velay martin-velay self-assigned this Dec 20, 2024
vogelpi
vogelpi approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@vogelpi vogelpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Can this really fix the issues with the stress_all_with_rand_reset test?

@martin-velay
Copy link
Contributor Author

This looks good to me!

Can this really fix the issues with the stress_all_with_rand_reset test?

It fixes only one of the issues, there are 1-2 other PR to handle some other parts . I ran 100 times this test with all the cherry-picked commits and no issue found.

@martin-velay
[hmac,dv] Move IDLE check from vseq to scb
a6fb29d 
- Move the IDLE pin check from the base sequence to the SCB as it makes
more sense to perform check there.

Signed-off-by: Martin Velay <mvelay@lowrisc.org>
@martin-velay martin-velay added the Component:DV DV issue: testbench, test case, etc. label Dec 23, 2024
rswarbrick
rswarbrick approved these changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks: this looks much nicer to me.

marcelocarvalhoLowRisc
marcelocarvalhoLowRisc reviewed Jan 3, 2025
View reviewed changes
Copy link

@marcelocarvalhoLowRisc marcelocarvalhoLowRisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agreed! Much better in the scoreboard.

@vogelpi vogelpi merged commit 39ca65f into lowRISC:master Jan 6, 2025
40 checks passed
@martin-velay martin-velay mentioned this pull request Jan 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelocarvalhoLowRisc marcelocarvalhoLowRisc marcelocarvalhoLowRisc left review comments

@vogelpi vogelpi vogelpi approved these changes

@rswarbrick rswarbrick rswarbrick approved these changes

Assignees

@martin-velay martin-velay

Labels
Component:DV DV issue: testbench, test case, etc. IP:hmac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martin-velay @rswarbrick @vogelpi @marcelocarvalhoLowRisc