AngularTest.php missing array in testSortRelationArrayDirective (#297)

* Update AngularTest.php a small typo, a defined list is missing from directives.js * @var object $options Provides options to build the sort relation array: * * ```js * { * 'sourceData': [ * {'value': 1, 'label': 'Source Entry #1'} * {'value': 2, 'label': 'Source Entry #2'} * {'value': 3, 'label': 'Source Entry #3'} * {'value': 4, 'label': 'Source Entry #4'} * ] * } * ``` * Update Angular.php * Ensure value and label as keys * Update Angular.php * Update AngularTest.php
luyadev · May 19, 2019 · d1b2c25 · d1b2c25
1 parent 6059ac9
commit d1b2c25
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/helpers/Angular.php b/src/helpers/Angular.php
@@ -141,7 +141,7 @@ public static function directive($name, array $options = [])
  */
  public static function sortRelationArray($ngModel, $label, array $sourceData, array $options = [])
  {
- return self::injector(TypesInterface::TYPE_SORT_RELATION_ARRAY, $ngModel, $label, ['sourceData' => $sourceData], $options);
+ return self::injector(TypesInterface::TYPE_SORT_RELATION_ARRAY, $ngModel, $label, ['sourceData' => static::optionsArrayInput($sourceData)], $options);
  }
 
  /**

diff --git a/tests/admin/helpers/AngularTest.php b/tests/admin/helpers/AngularTest.php
@@ -21,8 +21,8 @@ public function testTextDirective()
 
  public function testSortRelationArrayDirective()
  {
- $this->assertSame('<zaa-sort-relation-array model="the-model" label="the-label" options=\'{"sourceData":{"foo":"bar"}}\' fieldid="the-model-zaa-sort-relation-array" fieldname="the-model"></zaa-sort-relation-array>', Angular::sortRelationArray('the-model', 'the-label', ['foo' => 'bar'])->render());
- $this->assertSame('<zaa-sort-relation-array classAtr="value" model="the-model" label="the-label" options=\'{"sourceData":{"foo":"bar"}}\' fieldid="the-model-zaa-sort-relation-array" fieldname="the-model"></zaa-sort-relation-array>', Angular::sortRelationArray('the-model', 'the-label', ['foo' => 'bar'], ['classAtr' => 'value'])->render());
+ $this->assertSame('<zaa-sort-relation-array model="the-model" label="the-label" options=\'{"sourceData":[{"label":"bar","value":"foo"}]}\' fieldid="the-model-zaa-sort-relation-array" fieldname="the-model"></zaa-sort-relation-array>', Angular::sortRelationArray('the-model', 'the-label', ['foo' => 'bar'])->render());
+ $this->assertSame('<zaa-sort-relation-array classAtr="value" model="the-model" label="the-label" options=\'{"sourceData":[{"label":"bar","value":"foo"}]}\' fieldid="the-model-zaa-sort-relation-array" fieldname="the-model"></zaa-sort-relation-array>', Angular::sortRelationArray('the-model', 'the-label', ['foo' => 'bar'], ['classAtr' => 'value'])->render());
  }
 
  public function testCheckbox()