Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken TimePicker in News section #2

Closed
buttflattery opened this issue Dec 13, 2017 · 4 comments
Closed

Broken TimePicker in News section #2

buttflattery opened this issue Dec 13, 2017 · 4 comments
Assignees
Labels

Comments

@buttflattery
Copy link

  • OS Information: Windows 10 Pro
  • System Type: 64-bit OS x64-based Processor
  • Browser Info: Chrome Version 62.0.3202.94 (Official Build) (64-bit)
  • Browser Info : Firefox 57.0 (64-bit)

Demo seems to be broken at some sections like if you go to admin and try to create a new news and then select Date under time section the timepicker appears after selecting date but clicking it wont do anything and the layout seems to be broken as the hours and minutes are not aligned. The layout, it acts differently in both Chrome and Firefox although the timepicker does not work under both of them the layout seems to be ok in chrome but not in firefox here are the screen grabs for both the browsers

FIREFOX

image

CHROME

image

@nadar
Copy link
Member

nadar commented Dec 13, 2017

@buttflattery Okay thanks for the report. Actually there is no time picker so far :-) Just enter hour and minute

@buttflattery
Copy link
Author

ahh Ok! I thought that there is the icon of the clock so assumed there would be a timepicker that is missing.

@nadar
Copy link
Member

nadar commented Dec 13, 2017

@buttflattery Well, what you are saying is truly a user experience problem, an icon which promise something like the calendar does for the date. Thanks for the input.

@buttflattery
Copy link
Author

I am always with Yii 🥇

vavepl added a commit to vavepl/luya-module-admin that referenced this issue May 16, 2019
a small typo, a defined list is missing
from directives.js
* @var object $options Provides options to build the sort relation array:
     *
     * ```js
     * {
     * 	'sourceData': [
     * 		{'value': 1, 'label': 'Source Entry luyadev#1'}
     * 		{'value': 2, 'label': 'Source Entry luyadev#2'}
     * 		{'value': 3, 'label': 'Source Entry luyadev#3'}
     * 		{'value': 4, 'label': 'Source Entry luyadev#4'}
     * 	]
     * }
     * ```
nadar pushed a commit that referenced this issue May 19, 2019
* Update AngularTest.php

a small typo, a defined list is missing
from directives.js
* @var object $options Provides options to build the sort relation array:
     *
     * ```js
     * {
     * 	'sourceData': [
     * 		{'value': 1, 'label': 'Source Entry #1'}
     * 		{'value': 2, 'label': 'Source Entry #2'}
     * 		{'value': 3, 'label': 'Source Entry #3'}
     * 		{'value': 4, 'label': 'Source Entry #4'}
     * 	]
     * }
     * ```

* Update Angular.php

* Ensure value and label as keys

* Update Angular.php

* Update AngularTest.php
@nadar nadar closed this as completed in 5b14a43 Sep 13, 2019
slowfox089 referenced this issue in slowfox089/luya-module-admin Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants