Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Login Placeholder Layout #1

Closed
buttflattery opened this issue Dec 13, 2017 · 5 comments
Closed

Admin Login Placeholder Layout #1

buttflattery opened this issue Dec 13, 2017 · 5 comments
Assignees
@dev7ch
Labels
bug
Milestone
1.0.1

Comments

@buttflattery
Copy link

buttflattery commented Dec 13, 2017 •
edited
Loading

  • OS Information: Windows 10 Pro
  • System Type: 64-bit OS x64-based Processor
  • Browser Info: Chrome Version 62.0.3202.94 (Official Build) (64-bit)
  • Browser Info : Firefox 57.0 (64-bit)

The admin login interface where we provide the credentials if you directly copy the email inside the email input field the placeholder shows up like the following

image
@nadar nadar added the bug label Dec 13, 2017
@nadar
Copy link
Member

nadar commented Dec 13, 2017

@dev7ch @TheMaaarc Maybe we can watch this behavior with js?

@dev7ch
Copy link
Contributor

dev7ch commented Dec 14, 2017 •
edited
Loading

I think wachting the input in particular paste function should be possible.

But maybe AngluarJS could help with sth like:

<input type='text' ng-paste='handlePaste($event.clipboardData.getData('text/plain'))'>

please double check @TheMaaarc

@nadar
Copy link
Member

nadar commented Dec 14, 2017

The login form is not written in angular context.

@dev7ch dev7ch mentioned this issue Dec 20, 2017
Merged
@nadar nadar added this to the 1.0.1 milestone Dec 20, 2017
@nadar
Copy link
Member

nadar commented Dec 28, 2017

@dev7ch can someone confirm this is fixed? so we could close this issue.

@dev7ch
Copy link
Contributor

dev7ch commented Dec 29, 2017

i can confirm, paste and autofill are working fine now in Firefox and should work in other browser as well, so yes.

see https://github.com/luyadev/luya-module-admin/blob/master/src/resources/js/login.js#L106

@dev7ch dev7ch closed this as completed Dec 29, 2017
@nadar nadar mentioned this issue Apr 15, 2018
Closed
@Webkadabra Webkadabra mentioned this issue Jul 10, 2018
Closed
vavepl added a commit to vavepl/luya-module-admin that referenced this issue May 16, 2019
@vavepl
Update AngularTest.php
4924a87 
a small typo, a defined list is missing
from directives.js
* @var object $options Provides options to build the sort relation array:
     *
     * ```js
     * {
     * 	'sourceData': [
     * 		{'value': 1, 'label': 'Source Entry luyadev#1'}
     * 		{'value': 2, 'label': 'Source Entry luyadev#2'}
     * 		{'value': 3, 'label': 'Source Entry luyadev#3'}
     * 		{'value': 4, 'label': 'Source Entry luyadev#4'}
     * 	]
     * }
     * ```
nadar pushed a commit that referenced this issue May 19, 2019
@vavepl @nadar
AngularTest.php missing array in testSortRelationArrayDirective (#297)
d1b2c25 
* Update AngularTest.php

a small typo, a defined list is missing
from directives.js
* @var object $options Provides options to build the sort relation array:
     *
     * ```js
     * {
     * 	'sourceData': [
     * 		{'value': 1, 'label': 'Source Entry #1'}
     * 		{'value': 2, 'label': 'Source Entry #2'}
     * 		{'value': 3, 'label': 'Source Entry #3'}
     * 		{'value': 4, 'label': 'Source Entry #4'}
     * 	]
     * }
     * ```

* Update Angular.php

* Ensure value and label as keys

* Update Angular.php

* Update AngularTest.php
@nadar nadar mentioned this issue Sep 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dev7ch dev7ch

Labels
bug
Projects
None yet
Milestone
1.0.1
Development

No branches or pull requests
3 participants
@buttflattery @nadar @dev7ch