Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use storage system for uploading files when using sync #566

Merged
merged 15 commits into from
Sep 24, 2020
Merged

use storage system for uploading files when using sync #566

merged 15 commits into from
Sep 24, 2020

Conversation

nadar
Copy link
Member

@nadar nadar commented Sep 18, 2020

use the storage component to store new files, instead of static "storag" folder path

@nadar
Copy link
Member Author

nadar commented Sep 18, 2020

PHP Warning 'yii\base\ErrorException' with message 'file_exists() expects parameter 1 to be a valid path, string given'

in /app/vendor/luyadev/luya-core/helpers/FileHelper.php:152

Stack trace:
#0 [internal function]: yii\base\ErrorHandler->handleError()
#1 /app/vendor/luyadev/luya-core/helpers/FileHelper.php(152): file_exists()
#2 /app/vendor/luyadev/luya-module-admin/src/proxy/ClientTransfer.php(66): luya\helpers\FileHelper::md5sum()
#3 /app/vendor/luyadev/luya-module-admin/src/commands/ProxyController.php(226): luya\admin\proxy\ClientTransfer->start()

@codeclimate
Copy link

codeclimate bot commented Sep 24, 2020

Code Climate has analyzed commit e8aec64 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 80.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 50.7% (1.3% change).

View more on Code Climate.

@nadar nadar merged commit 8184077 into master Sep 24, 2020
@nadar nadar deleted the sync-command-with-storage-component branch September 24, 2020 13:02
slowfox089 pushed a commit to slowfox089/luya-module-admin that referenced this pull request Dec 10, 2020
@nadar @slowfox089
use storage system for uploading files when using sync (luyadev#566)
507668e 
* use storage system for uploading files when using sync

* fix syntax error

* update

* return md5 from temp file

* add very basic test

* add further test

* add file fixture and changelog

* use system file name

* use system file name

* add test

* add test

* add false test

* add image content

* add image test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nadar