Configurable variants saving to cache OLD #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 5, 2020 16:14
-Module and changes to existing infrastructure to support product variants -Added configurable product variants -Added tests for product variants
Minor syntax fixes
7 tasks
added 6 commits
November 5, 2020 17:26
-Changed entity type to string
-Test fixes
-Minor fixes
-Moved test from variants to configurable variants and other minor adjustments
|
@magento run all tests |
| * @param string[] $ids | ||
| * @return \Magento\CatalogExportApi\Api\Data\ProductVariant[] | ||
| */ | ||
| public function get(array $ids): array; |
There was a problem hiding this comment.
where this API is used?
There was a problem hiding this comment.
\Magento\CatalogMessageBroker\Model\FetchProductVariants::execute
The getByProductIds is currently not really used, however I think we will likely need it in future so I added it.
Comment on lines
24
to
27
| public function resolve(string ...$params): string | ||
| { | ||
| array_unshift($params, ConfigurableOptionValueUid::OPTION_TYPE); | ||
| return implode('/', $params); |
There was a problem hiding this comment.
propose to change a little bit this approach to make is more safe, because in this case we do not know nothing about order of incoming parameters
// \Magento\ConfigurableProductDataExporter\Model\Provider\Product\ProductVariants::getVariants
$id = $idResolver->resolve(\...(['parentId' => $row['parentId'], 'childId' => $row['childId']));
....
in this case we can control data:
$params = [
'parentId' => $row['parentId'],
'childId' => $row['childId']
];
| use Magento\DataExporter\Exception\UnableRetrieveData; | ||
| use Magento\Framework\App\ResourceConnection; | ||
| use Psr\Log\LoggerInterface; | ||
|
|
||
| /** | ||
| * Configurable product variant data provider | ||
| * TODO: Deprecated. Remove this class and its query class. |
There was a problem hiding this comment.
please add id of the issue here
-Comment fix -Made product variant id provider params more defined
RuslanKostiv1
added a commit
to RuslanKostiv1/commerce-data-export
that referenced
this pull request
Nov 10, 2020
…ta-provider MC-29580: Complex product data provider
RuslanKostiv1
pushed a commit
to RuslanKostiv1/commerce-data-export
that referenced
this pull request
Nov 10, 2020
SF API test for categories and product dynamic attributes
added 4 commits
November 11, 2020 21:46
-Removed indexation reliance on product index -Changed mview to product_relations
-Fixed indexing issues
bricht
changed the title
skovalenk
pushed a commit
to skovalenk/commerce-data-export
that referenced
this pull request
Dec 1, 2020
…ommerce-data-export-3 [Imported] Category Breadcrumb sort order
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Nov 4, 2021
MDEE-46: Prepare queries to get stock item status data from Magento
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Module and changes to existing infrastructure to support product variants
-Added configurable product variants
-Added tests for product variants
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Questions or comments
Code Review Checklist (*)