Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

magento/devdocs#: Cloud. Set ADMIN_URL via magneto-cloud command-line tool #5971

Merged
merged 6 commits into from
Nov 19, 2019

Conversation

atwixfirster
Copy link
Contributor

Purpose of this pull request

Magento support recommends to use magento-cloud command line tool to change the alias of magento back-end.

This pull request (PR) adds a link to an example how to set Admin URL via magento-cloud command line tool.

Affected DevDocs pages

Links to Magento source code

Thank you!

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this Nov 12, 2019
@rogyar rogyar added 2.2.x 2.3.x Magento 2.3 related changes labels Nov 12, 2019
Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Yes, this needs changing, but found another possible change.

@atwixfirster atwixfirster force-pushed the cloud-set-ADMIN_URL branch 2 times, most recently from 5dd5426 to cebe212 Compare November 12, 2019 15:23
@hguthrie
Copy link
Contributor

@atwixfirster I am looking into the fact that some variables cannot be set in this way. I don't see where the Cloud docs explicitly calls these out and so you may have stumbled on an opportunity where we can bring clear attention to this. I'll let you know what I find out...

@hguthrie hguthrie added the Waiting for Response Waiting for response from internal/external parties label Nov 12, 2019
@hguthrie
Copy link
Contributor

You can use the Magento Cloud CLI or web UI to update those variables for the Magento installation. After the Magento installation, you can not update user data in the same way. You would have to use the bin/magento admin:user method.

@hguthrie hguthrie removed the Waiting for Response Waiting for response from internal/external parties label Nov 14, 2019
@atwixfirster
Copy link
Contributor Author

You can use the Magento Cloud CLI or web UI to update those variables for the Magento installation. After the Magento installation, you can not update user data in the same way. You would have to use the bin/magento admin:user method.

@hguthrie , I do not understand. Per your comment I can not use

magento-cloud variable:set ADMIN_URL magento_A8v10 -e master

to change ADMIN_URL after Magento installation?

Thank you!

@hguthrie
Copy link
Contributor

Yes, the validator checks that ADMIN_EMAIL, ADMIN_USERNAME, ADMIN_FIRSTNAME, ADMIN_LASTNAME, and ADMIN_PASSWORD are used only during installation.

@atwixfirster
Copy link
Contributor Author

Yes, the validator checks that ADMIN_EMAIL, ADMIN_USERNAME, ADMIN_FIRSTNAME, ADMIN_LASTNAME, and ADMIN_PASSWORD are used only during installation.

I've reverted back my changes regarding your notice.

Could you please review a final version.

Thank you, @hguthrie !

@hguthrie hguthrie added the Technical Updates to the code or processes that alter the technical content of the doc label Nov 14, 2019
@hguthrie
Copy link
Contributor

running tests

@hguthrie
Copy link
Contributor

running tests

@hguthrie
Copy link
Contributor

This keeps failing build:

  *  _site/guides/v2.3/cloud/env/environment-vars_magento.html (line 305)
     <a href="/guides/v2.3/cloud/env/set-variables.html"></a>```


## Admin URL

Use the following environment variable to secure access to your Magento Admin UI. If specified, this value overrides the default URL during installation.

`ADMIN_URL`—The relative URL to access the Magento Admin UI. The default URL is `/admin`. For security reasons, Magento recommends that you change the default to a unique, custom Admin URL that is not easy to guess.

If you need to change the Admin URL after installation, connect to your environment using SSH and use the Magento CLI [`magento setup:config`]({{ page.baseurl }}/install-gde/install/cli/install-cli-subcommands-deployment.html) command to change the URL.
If you need to change the Admin URL after installation, use the [`magento-cloud variable:set`]({{ page.baseurl }}/cloud/env/set-variables.html) command-line tool to change the URL.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the broken link, do you think this would be an appropriate link to use?
https://devdocs.magento.com/guides/v2.2/cloud/before/before-setup-env-2_clone.html#change-the-magento-admin-variables

Copy link
Contributor Author

@atwixfirster atwixfirster Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atwixfirster
Copy link
Contributor Author

This keeps failing build:

  *  _site/guides/v2.3/cloud/env/environment-vars_magento.html (line 305)
     <a href="/guides/v2.3/cloud/env/set-variables.html"></a>```

I've fixed a content. Removed link and added an example from https://devdocs.magento.com/guides/v2.2/cloud/env/set-variables.html ;)

It will help to pass tests.

@hguthrie , could you please review?

Thank you!

Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better! Less maintenance.

@hguthrie
Copy link
Contributor

running tests

@hguthrie hguthrie merged commit 8d71e11 into magento:master Nov 19, 2019
@ghost
Copy link

ghost commented Nov 19, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@hguthrie
Copy link
Contributor

Victory! 🏆

@atwixfirster
Copy link
Contributor Author

Victory! 🏆

yep

Thanks, @hguthrie 🌸

keharper added a commit that referenced this pull request Nov 27, 2019
* Update first-time-setup-import-import.md

* adding new information from stopwords elasticsearch

* settings

* settings

* settings spaces

* settings by MD029

* settings by MD029

* adding variable from github url tree

* adding url variable

* adding fix MD009

* Using the /search endpoint

* Update rest-api.yml

* Update search-endpoint.md

* Update search-endpoint.md

* Updates as per request points

* Symlink for v2.3

* Symlink modification

* Updated repo path

* Update search-endpoint.md

* Fixed double quotes.

* Google 3.0.2 - RN

Initial Draft

* Outline differences between search types and v1/search and v1/products

* Update search-endpoint.md

* Added PHP note

added a note regarding required PHP setting for Google reCAPTCHA. This update was vetted and approved by Rick Tempesta.

* Update guides/v2.3/security/google-recaptcha.md

Accepted approver's suggestion

Co-Authored-By: Shrie Spangler <spangler@adobe.com>

* fixed broken link

* removing variable and remove link for example

* Added JS script name resolution examples

* Fixed incorrect syntax for custom KO checked binding

* Added missing example for i18n Magento binding syntax

* Incorrect reference url fixed

The reference url was pointing to Customer/Api instead of Catalog/Api

* Fixing the LESS snippet syntax

* Added note for ece-tools patch process fix (#6004)

* Added fix for patch process issue introduced
  by version scheme change for 
  security only patches in Magento 2.3.2-p2.

* Updates yml. Delete unused file.

* Fixed typo.

* Linting

* Grammar and formatting

* Trailing space

* Trailing spaces

* Google 3.0.2 updates

release notes, release, compatibility.

* Markdown linting: Enable rule MD036 (emphasis used instead of a header) (#6023)

* Added colons to common psuedo-headers

* Added colons to less common psuedo headers

* Added colons to more less common psuedo headers

* Removed emphasis from captions

* Fixed up links.

* Added note for ece-tools patch process fix (#6004) (#6020)

* Added fix for patch process issue introduced
  by version scheme change for
  security only patches in Magento 2.3.2-p2.

* Corrected RESOURCE_CONFIGURATION merge example (#6005)

* Fixes #6025

* updated compatible versions

added 2.3.3

* Update extensions/google-shopping-ads/release-notes/index.md

Co-Authored-By: Shrie Spangler <spangler@adobe.com>

* Update extensions/google-shopping-ads/release-notes/index.md

Co-Authored-By: Shrie Spangler <spangler@adobe.com>

* Grammar and formatting

* magento/devdocs#: Cloud. Set ADMIN_URL via magneto-cloud command-line tool (#5971)

* magento/devdocs#: Cloud. Set ADMIN_URL via magneto-cloud command line tool

- https://devdocs.magento.com/guides/v2.2/cloud/env/environment-vars_magento.html
- https://devdocs.magento.com/guides/v2.3/cloud/env/environment-vars_magento.html

* magento/devdocs#: Cloud. Set ADMIN_URL via magneto-cloud command line tool

* Update rake build:prod

Add init task to prerequisites.

* Adding question mark when nullable value is declared

* Adding nullable param question mark in v2.2

* #5632: Incorrect link to JSCS site.

https://devdocs.magento.com/guides/v2.2/coding-standards/code-standard-javascript.html
https://devdocs.magento.com/guides/v2.3/coding-standards/code-standard-javascript.html

* Updated What's New with changes since November 4 (#6030)

* Updated What's New with changes since November 4

* Merge UI component PRs (#6041)

* Update Paging UI component documentation (#6039)

* Update Paging UI component documentation

* Grammar updates

* Update DragAndDrop UI component documentation (#6038)

* Update DragAndDrop UI component documentation

* Grammar updates

* Update date column UI component documentation (#6037)

* Update date column UI component documentation

* Grammar update

* Update ui columns documentation (#6036)

* Update ui columns documentation

* Adjust the example title

* Grammar updates

* Update UI column component documentation (#6034)

* Update UI column component documentation

* Update ui-column.md

* fixed linting error

* removing Google 3.0.2 info

will republish when 3.0.2 is released.

* update whatsnew

remove google 3.0.2 release notes from whatsnew

* magento/devdocs#: Add customerOrders query API errors

- https://devdocs.magento.com/guides/v2.3/graphql/queries/customer-orders.html

* magento/devdocs#: Add customerDownloadableProducts query API errors

- https://devdocs.magento.com/guides/v2.3/graphql/queries/customer-downloadable-products.html

* Optimized Index Management screen capture (#6050)

* Updated Architecture topic for Starter plan (#6043)

Per @jefflathan1:  Starter stores are not entitled to TAms in the same way that Pro stores are. We need to remove the Technical Account Manager entry for Starter, leaving it blank.

* #5218: Need info about structures in Adding a custom indexer (#6042)

* #5218:  Need info about structures in Adding a custom indexer

https://devdocs.magento.com/guides/v2.2/extension-dev-guide/indexing-custom.html
https://devdocs.magento.com/guides/v2.3/extension-dev-guide/indexing-custom.html

* Grammar updates

@atwixfirster I made many grammatical changes. Please review my changes, especially the `shared_index`  description,

* Updating Fieldset UiComponent documentation (#6045)

* Adding the Fieldset UiComponent additional information

* Updating the example

* Minor adjustments

* Update ui-fieldset.md

* Update view-models.md

I wasn't closing a tag page

* GraphQL caching with Fastly (#6031)

* GraphQL caching with Fastly

* Update guides/v2.3/graphql/caching.md

Co-Authored-By: Margaret Eker <meker@adobe.com>

* Added steps to check Fastly version on Cloud

* Fixed syntax

* Apply suggestions from code review

* Editorial fixes

* Apply suggestions from code review

Co-Authored-By: Margaret Eker <meker@adobe.com>

* Delete space at end of sentence

* Update caching.md

* GraphQL: small changes (#6052)

* removing cloud bi from toc

* Editorial fix (#6054)

* GraphQL caching with Fastly

* Update guides/v2.3/graphql/caching.md

Co-Authored-By: Margaret Eker <meker@adobe.com>

* Added steps to check Fastly version on Cloud

* Fixed syntax

* Apply suggestions from code review

* Editorial fixes

* Apply suggestions from code review

Co-Authored-By: Margaret Eker <meker@adobe.com>

* Delete space at end of sentence

* Update caching.md

* Editorial fix

* Add MBI to search and update site switcher (#6062)

* KB migration: Restore an environment (#6063)

* Added new topic and TOC entry

* Added files

* Added optimized images

* Fixed markdown

* Rewrote content

* Fixed links

* Fixed MD errors

* Added xref to new topic

* Fixed xref

* Apply suggestions from code review

Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com>

* Revised per peer review

* Missed a var

* Apply suggestions from code review

Co-Authored-By: Margaret Eker <meker@adobe.com>

* Fixed incorrect terminology and added references

* Converting the Display Magento error report number KB to devdocs (#6061)

* Converting the Display Magento error report number KB to devdocs

* ElasticSearch: Nigix proxy config correction

* Set warning for STATIC_CONTENT_SYMLINK variable (#6065)

* Add STATIC_CONTENT_SYMLINK removal note

* Remove ece-version tool

* Add additional note

* Add supported service versions of RabbitMQ

From the platform.sh docs https://docs.platform.sh/configuration/services/rabbitmq.html

* Updating cli documentation

* Add link to supported version list

* Remove remote_markdown completely

* Fix site variable

* Add example for local RabbitMQ Management UI

* Little changes

* Update guides/v2.2/mtf/configuration.md

Editorial fix

Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>

* Update guides/v2.2/mtf/configuration.md

Editorial fix

Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>

* Update guides/v2.2/mtf/configuration.md

Editorial fix

Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>

* Update guides/v2.2/mtf/mtf_entities/mtf_handler.md

Editorial fix

Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>

* Fix style

* Small formatting change.

* Resolve code quotation error. (#6072)

* Add docs for new Adobe-generated alert policies for New Relic (#6075)

- Updated New Relic topic to add Adobe-generated alert policies
- Added information about New Relic monitoring to the
following topics: Architecture, and Go Live checklist
- Added new Monitor Performance topic to Manage Project section
- Added images for New Relic alert policies and project credentials

* fix linting error
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.2.x 2.3.x Magento 2.3 related changes Partner: Atwix partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants