This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Added note for ece-tools patch process fix #6004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meker12
added
2.x
Internal Dev
meker12
commented
Nov 15, 2019
meker12
commented
Nov 15, 2019
hguthrie
reviewed
Nov 15, 2019
|
|
||
| - {:.new}Updated the `composer.json` file for the `{{ site.data.var.ct }}` package to add a dependency for the `magento/magento-cloud-patches` v1.0.0 package. | ||
|
|
||
| - {:.fix}<!--MAGECLOUD-4661-->Fixed an issue that caused the `{{ site.data.var.ct }}` patching process to fail when applying security-only patches for versions 2.3.2 and later. This issue was introduced by the new versioning scheme adopted for security-only patches in {{ site.data.var.ee }} v2.3.3. See [Security-only patches]({{ site.baseurl }}/guides/v2.3/release-notes/bk-release-notes.html#security-only-patches). |
There was a problem hiding this comment.
Maybe specify "Magento version 2.3.2 and later"
YPyltiai
suggested changes
Nov 15, 2019
|
|
||
| - {:.new}Updated the `composer.json` file for the `{{ site.data.var.ct }}` package to add a dependency for the `magento/magento-cloud-patches` v1.0.0 package. | ||
|
|
||
| - {:.fix}<!--MAGECLOUD-4661-->Fixed an issue that caused the `{{ site.data.var.ct }}` patching process to fail when applying security-only patches for versions 2.3.2 and later releases. This issue was introduced by the new versioning scheme adopted for security-only patches in {{ site.data.var.ee }} v2.3.3. See [Security-only patches]({{ site.baseurl }}/guides/v2.3/release-notes/bk-release-notes.html#security-only-patches). |
There was a problem hiding this comment.
Not fail but skip patches, which were expected to apply, causing no patches to be applied at all. This can be better re-worded, it's just the issue itself.
Also I would change ...security-only patches for versions 2.3.2 and later releases. to ...2.3.2-p2 release and any future security-only releases.
Let's call security-only patches as security-only releases to avoid confusion with actual patches (hotfixes), which we fixed. Also new scheme was adopted starting 2.3.2 with 2.3.2-p2 release.
YPyltiai
reviewed
Nov 15, 2019
|
|
||
| - {:.new}Updated the `composer.json` file for the `{{ site.data.var.ct }}` package to add a dependency for the `magento/magento-cloud-patches` v1.0.0 package. | ||
|
|
||
| - {:.fix}<!--MAGECLOUD-4661-->Fixed an issue that caused the `{{ site.data.var.ct }}` patching process to break when applying patch sets that include security-only patches for Magento version 2.3.2 and later . This issue was introduced by the new versioning scheme adopted for [security-only patches]({{ site.baseurl }}/guides/v2.3/release-notes/bk-release-notes.html#security-only-patches) starting with the {{ site.data.var.ee }} version 2.3.2-p2. |
There was a problem hiding this comment.
when applying patch sets that include security-only patches for Magento version 2.3.2 and later -> when applying patch sets on top of security-only releases, starting with Magento 2.3.2-p2 and later
meker12
commented
Nov 15, 2019
meker12
commented
Nov 15, 2019
YPyltiai
approved these changes
Nov 18, 2019
hguthrie
approved these changes
Nov 18, 2019
|
running tests |
|
Hi @meker12, thank you for your contribution! |
meker12
added a commit
that referenced
this pull request
Nov 18, 2019
* Added fix for patch process issue introduced by version scheme change for security only patches in Magento 2.3.2-p2.
meker12
added a commit
that referenced
this pull request
Nov 18, 2019
keharper
added a commit
that referenced
this pull request
Nov 19, 2019
* Update first-time-setup-import-import.md * adding new information from stopwords elasticsearch * settings * settings * settings spaces * settings by MD029 * settings by MD029 * adding variable from github url tree * adding url variable * adding fix MD009 * Updated repo path * Fixed double quotes. * Fixed incorrect module dependency examples * update file extension * Fix small grammatical issue - Missing article * Fixed incorrect link syntax * Fix staging Use double quotes for Build number variable in rake build:stage * Fix staging Replace a bash variable with ENV syntax in rake build:stage * Improving the Range UiComponent * Improving the Checkbox UiComponent documentation * magento/devdocs#: Add deleteCustomerAddress mutation API errors - https://devdocs.magento.com/guides/v2.3/graphql/mutations/delete-customer-address.html * Adding the widget available options * Update theme-create.md * Product availability updates (#5984) * Added product recs * Added qualification for Google extension * magento/devdocs#: Add updateCustomerAddress mutation API errors - https://devdocs.magento.com/guides/v2.3/graphql/mutations/update-customer-address.html * Editing for grammar * Editing for grammar * Table formatting * Grammar * magento/devdocs#: Extends information about creating a dynamic row system config. - https://devdocs.magento.com/guides/v2.2/ext-best-practices/tutorials/dynamic-row-system-config.html - https://devdocs.magento.com/guides/v2.3/ext-best-practices/tutorials/dynamic-row-system-config.html * Add site switcher to the header (#5983) * Add site switcher to the header * Change site-nav.html to add the button * Add contributor metadata info * Removed workflows file * Change wording Change mention of notation to "attribution" and implement limitation on accepted links per Jeff's review * Added PHP note added a note regarding required PHP setting for Google reCAPTCHA. This update was vetted and approved by Rick Tempesta. * Small grammar fix * [ImgBot] Optimize images /common/images/ext-best-practices/dynamic-rows-config-result.png -- 61.37kb -> 30.32kb (50.59%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> * Update database-caching.md Fix Identation of XML code. * Adding new example New example using SearchCriteria with getList * Update create-cache-type.md Namespace not is in default model used by Magento FrameWork * Update lifecycle.md Alter definition of class, not good practice. * Add rake index with dry run * Cloud 2002.0.22 (#5997) - Consolidate versioned release notes to one topic - Replace v2.3 release notes with symlink - Add section for 2002.0.22 release notes - Remove obsolete version information from the Cloud TOC file - Revised release notes to explain changes to ece-tools and cloud patches components more clearly and concisely - Changed list of patches to fixes * Update rake multirepo:init Use ruby syntax for environment variable Exit if rake init fails on checkout * Typo fix * Update rake index Remove --dry-run Add output message * Refactor rake init Replaced 'print + exit' with equal 'abort' * Update rake mutirepo tasks Add rake reinit Refactor * Formatting * Formatting * Add caution for 'rake multirepo:reinit' * Remove typos in command * Update guides/v2.3/security/google-recaptcha.md Accepted approver's suggestion Co-Authored-By: Shrie Spangler <spangler@adobe.com> * fixed broken link * removing variable and remove link for example * Added JS script name resolution examples * Added note for ece-tools patch process fix (#6004) * Added fix for patch process issue introduced by version scheme change for security only patches in Magento 2.3.2-p2. * Updates yml. Delete unused file. * Fixed typo. * Linting * Grammar and formatting * Trailing spaces * Markdown linting: Enable rule MD036 (emphasis used instead of a header) (#6023) * Added colons to common psuedo-headers * Added colons to less common psuedo headers * Added colons to more less common psuedo headers * Removed emphasis from captions * fix linting problems for text added in 2.3.4
keharper
added a commit
that referenced
this pull request
Nov 27, 2019
* Update first-time-setup-import-import.md * adding new information from stopwords elasticsearch * settings * settings * settings spaces * settings by MD029 * settings by MD029 * adding variable from github url tree * adding url variable * adding fix MD009 * Using the /search endpoint * Update rest-api.yml * Update search-endpoint.md * Update search-endpoint.md * Updates as per request points * Symlink for v2.3 * Symlink modification * Updated repo path * Update search-endpoint.md * Fixed double quotes. * Google 3.0.2 - RN Initial Draft * Outline differences between search types and v1/search and v1/products * Update search-endpoint.md * Added PHP note added a note regarding required PHP setting for Google reCAPTCHA. This update was vetted and approved by Rick Tempesta. * Update guides/v2.3/security/google-recaptcha.md Accepted approver's suggestion Co-Authored-By: Shrie Spangler <spangler@adobe.com> * fixed broken link * removing variable and remove link for example * Added JS script name resolution examples * Fixed incorrect syntax for custom KO checked binding * Added missing example for i18n Magento binding syntax * Incorrect reference url fixed The reference url was pointing to Customer/Api instead of Catalog/Api * Fixing the LESS snippet syntax * Added note for ece-tools patch process fix (#6004) * Added fix for patch process issue introduced by version scheme change for security only patches in Magento 2.3.2-p2. * Updates yml. Delete unused file. * Fixed typo. * Linting * Grammar and formatting * Trailing space * Trailing spaces * Google 3.0.2 updates release notes, release, compatibility. * Markdown linting: Enable rule MD036 (emphasis used instead of a header) (#6023) * Added colons to common psuedo-headers * Added colons to less common psuedo headers * Added colons to more less common psuedo headers * Removed emphasis from captions * Fixed up links. * Added note for ece-tools patch process fix (#6004) (#6020) * Added fix for patch process issue introduced by version scheme change for security only patches in Magento 2.3.2-p2. * Corrected RESOURCE_CONFIGURATION merge example (#6005) * Fixes #6025 * updated compatible versions added 2.3.3 * Update extensions/google-shopping-ads/release-notes/index.md Co-Authored-By: Shrie Spangler <spangler@adobe.com> * Update extensions/google-shopping-ads/release-notes/index.md Co-Authored-By: Shrie Spangler <spangler@adobe.com> * Grammar and formatting * magento/devdocs#: Cloud. Set ADMIN_URL via magneto-cloud command-line tool (#5971) * magento/devdocs#: Cloud. Set ADMIN_URL via magneto-cloud command line tool - https://devdocs.magento.com/guides/v2.2/cloud/env/environment-vars_magento.html - https://devdocs.magento.com/guides/v2.3/cloud/env/environment-vars_magento.html * magento/devdocs#: Cloud. Set ADMIN_URL via magneto-cloud command line tool * Update rake build:prod Add init task to prerequisites. * Adding question mark when nullable value is declared * Adding nullable param question mark in v2.2 * #5632: Incorrect link to JSCS site. https://devdocs.magento.com/guides/v2.2/coding-standards/code-standard-javascript.html https://devdocs.magento.com/guides/v2.3/coding-standards/code-standard-javascript.html * Updated What's New with changes since November 4 (#6030) * Updated What's New with changes since November 4 * Merge UI component PRs (#6041) * Update Paging UI component documentation (#6039) * Update Paging UI component documentation * Grammar updates * Update DragAndDrop UI component documentation (#6038) * Update DragAndDrop UI component documentation * Grammar updates * Update date column UI component documentation (#6037) * Update date column UI component documentation * Grammar update * Update ui columns documentation (#6036) * Update ui columns documentation * Adjust the example title * Grammar updates * Update UI column component documentation (#6034) * Update UI column component documentation * Update ui-column.md * fixed linting error * removing Google 3.0.2 info will republish when 3.0.2 is released. * update whatsnew remove google 3.0.2 release notes from whatsnew * magento/devdocs#: Add customerOrders query API errors - https://devdocs.magento.com/guides/v2.3/graphql/queries/customer-orders.html * magento/devdocs#: Add customerDownloadableProducts query API errors - https://devdocs.magento.com/guides/v2.3/graphql/queries/customer-downloadable-products.html * Optimized Index Management screen capture (#6050) * Updated Architecture topic for Starter plan (#6043) Per @jefflathan1: Starter stores are not entitled to TAms in the same way that Pro stores are. We need to remove the Technical Account Manager entry for Starter, leaving it blank. * #5218: Need info about structures in Adding a custom indexer (#6042) * #5218: Need info about structures in Adding a custom indexer https://devdocs.magento.com/guides/v2.2/extension-dev-guide/indexing-custom.html https://devdocs.magento.com/guides/v2.3/extension-dev-guide/indexing-custom.html * Grammar updates @atwixfirster I made many grammatical changes. Please review my changes, especially the `shared_index` description, * Updating Fieldset UiComponent documentation (#6045) * Adding the Fieldset UiComponent additional information * Updating the example * Minor adjustments * Update ui-fieldset.md * Update view-models.md I wasn't closing a tag page * GraphQL caching with Fastly (#6031) * GraphQL caching with Fastly * Update guides/v2.3/graphql/caching.md Co-Authored-By: Margaret Eker <meker@adobe.com> * Added steps to check Fastly version on Cloud * Fixed syntax * Apply suggestions from code review * Editorial fixes * Apply suggestions from code review Co-Authored-By: Margaret Eker <meker@adobe.com> * Delete space at end of sentence * Update caching.md * GraphQL: small changes (#6052) * removing cloud bi from toc * Editorial fix (#6054) * GraphQL caching with Fastly * Update guides/v2.3/graphql/caching.md Co-Authored-By: Margaret Eker <meker@adobe.com> * Added steps to check Fastly version on Cloud * Fixed syntax * Apply suggestions from code review * Editorial fixes * Apply suggestions from code review Co-Authored-By: Margaret Eker <meker@adobe.com> * Delete space at end of sentence * Update caching.md * Editorial fix * Add MBI to search and update site switcher (#6062) * KB migration: Restore an environment (#6063) * Added new topic and TOC entry * Added files * Added optimized images * Fixed markdown * Rewrote content * Fixed links * Fixed MD errors * Added xref to new topic * Fixed xref * Apply suggestions from code review Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com> * Revised per peer review * Missed a var * Apply suggestions from code review Co-Authored-By: Margaret Eker <meker@adobe.com> * Fixed incorrect terminology and added references * Converting the Display Magento error report number KB to devdocs (#6061) * Converting the Display Magento error report number KB to devdocs * ElasticSearch: Nigix proxy config correction * Set warning for STATIC_CONTENT_SYMLINK variable (#6065) * Add STATIC_CONTENT_SYMLINK removal note * Remove ece-version tool * Add additional note * Add supported service versions of RabbitMQ From the platform.sh docs https://docs.platform.sh/configuration/services/rabbitmq.html * Updating cli documentation * Add link to supported version list * Remove remote_markdown completely * Fix site variable * Add example for local RabbitMQ Management UI * Little changes * Update guides/v2.2/mtf/configuration.md Editorial fix Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com> * Update guides/v2.2/mtf/configuration.md Editorial fix Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com> * Update guides/v2.2/mtf/configuration.md Editorial fix Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com> * Update guides/v2.2/mtf/mtf_entities/mtf_handler.md Editorial fix Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com> * Fix style * Small formatting change. * Resolve code quotation error. (#6072) * Add docs for new Adobe-generated alert policies for New Relic (#6075) - Updated New Relic topic to add Adobe-generated alert policies - Added information about New Relic monitoring to the following topics: Architecture, and Go Live checklist - Added new Monitor Performance topic to Manage Project section - Added images for New Relic alert policies and project credentials * fix linting error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Updated the release notes for ece-tools package v2002.0.22 to include information about the fix for the patching process when applying security-only patches for Magento Commerce version 2.3.2 and later.
Affected DevDocs pages
https://devdocs.magento.com/guides/v2.3/cloud/release-notes/cloud-tools.html