This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Add site switcher to the header #5983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belbiy
added
the
Site Improvements
jeff-matthews
approved these changes
Nov 12, 2019
|
running tests |
|
Hi @belbiy, thank you for your contribution! |
keharper
added a commit
that referenced
this pull request
Nov 18, 2019
* Fixed incorrect module dependency examples * update file extension * Fix small grammatical issue - Missing article * Fixed incorrect link syntax * Fix staging Use double quotes for Build number variable in rake build:stage * Fix staging Replace a bash variable with ENV syntax in rake build:stage * Improving the Range UiComponent * Improving the Checkbox UiComponent documentation * magento/devdocs#: Add deleteCustomerAddress mutation API errors - https://devdocs.magento.com/guides/v2.3/graphql/mutations/delete-customer-address.html * Adding the widget available options * Update theme-create.md * Product availability updates (#5984) * Added product recs * Added qualification for Google extension * magento/devdocs#: Add updateCustomerAddress mutation API errors - https://devdocs.magento.com/guides/v2.3/graphql/mutations/update-customer-address.html * Editing for grammar * Editing for grammar * Table formatting * Grammar * magento/devdocs#: Extends information about creating a dynamic row system config. - https://devdocs.magento.com/guides/v2.2/ext-best-practices/tutorials/dynamic-row-system-config.html - https://devdocs.magento.com/guides/v2.3/ext-best-practices/tutorials/dynamic-row-system-config.html * Add site switcher to the header (#5983) * Add site switcher to the header * Change site-nav.html to add the button * Add contributor metadata info * Removed workflows file * Change wording Change mention of notation to "attribution" and implement limitation on accepted links per Jeff's review * Added PHP note added a note regarding required PHP setting for Google reCAPTCHA. This update was vetted and approved by Rick Tempesta. * Small grammar fix * [ImgBot] Optimize images /common/images/ext-best-practices/dynamic-rows-config-result.png -- 61.37kb -> 30.32kb (50.59%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> * Update database-caching.md Fix Identation of XML code. * Adding new example New example using SearchCriteria with getList * Update create-cache-type.md Namespace not is in default model used by Magento FrameWork * Update lifecycle.md Alter definition of class, not good practice. * Add rake index with dry run * Cloud 2002.0.22 (#5997) - Consolidate versioned release notes to one topic - Replace v2.3 release notes with symlink - Add section for 2002.0.22 release notes - Remove obsolete version information from the Cloud TOC file - Revised release notes to explain changes to ece-tools and cloud patches components more clearly and concisely - Changed list of patches to fixes * Update rake multirepo:init Use ruby syntax for environment variable Exit if rake init fails on checkout * Typo fix * Update rake index Remove --dry-run Add output message * Refactor rake init Replaced 'print + exit' with equal 'abort' * Update rake mutirepo tasks Add rake reinit Refactor * Formatting * Formatting * Add caution for 'rake multirepo:reinit' * Remove typos in command * Update guides/v2.3/security/google-recaptcha.md Accepted approver's suggestion Co-Authored-By: Shrie Spangler <spangler@adobe.com> * fixed broken link
keharper
added a commit
that referenced
this pull request
Nov 19, 2019
* Update first-time-setup-import-import.md * adding new information from stopwords elasticsearch * settings * settings * settings spaces * settings by MD029 * settings by MD029 * adding variable from github url tree * adding url variable * adding fix MD009 * Updated repo path * Fixed double quotes. * Fixed incorrect module dependency examples * update file extension * Fix small grammatical issue - Missing article * Fixed incorrect link syntax * Fix staging Use double quotes for Build number variable in rake build:stage * Fix staging Replace a bash variable with ENV syntax in rake build:stage * Improving the Range UiComponent * Improving the Checkbox UiComponent documentation * magento/devdocs#: Add deleteCustomerAddress mutation API errors - https://devdocs.magento.com/guides/v2.3/graphql/mutations/delete-customer-address.html * Adding the widget available options * Update theme-create.md * Product availability updates (#5984) * Added product recs * Added qualification for Google extension * magento/devdocs#: Add updateCustomerAddress mutation API errors - https://devdocs.magento.com/guides/v2.3/graphql/mutations/update-customer-address.html * Editing for grammar * Editing for grammar * Table formatting * Grammar * magento/devdocs#: Extends information about creating a dynamic row system config. - https://devdocs.magento.com/guides/v2.2/ext-best-practices/tutorials/dynamic-row-system-config.html - https://devdocs.magento.com/guides/v2.3/ext-best-practices/tutorials/dynamic-row-system-config.html * Add site switcher to the header (#5983) * Add site switcher to the header * Change site-nav.html to add the button * Add contributor metadata info * Removed workflows file * Change wording Change mention of notation to "attribution" and implement limitation on accepted links per Jeff's review * Added PHP note added a note regarding required PHP setting for Google reCAPTCHA. This update was vetted and approved by Rick Tempesta. * Small grammar fix * [ImgBot] Optimize images /common/images/ext-best-practices/dynamic-rows-config-result.png -- 61.37kb -> 30.32kb (50.59%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> * Update database-caching.md Fix Identation of XML code. * Adding new example New example using SearchCriteria with getList * Update create-cache-type.md Namespace not is in default model used by Magento FrameWork * Update lifecycle.md Alter definition of class, not good practice. * Add rake index with dry run * Cloud 2002.0.22 (#5997) - Consolidate versioned release notes to one topic - Replace v2.3 release notes with symlink - Add section for 2002.0.22 release notes - Remove obsolete version information from the Cloud TOC file - Revised release notes to explain changes to ece-tools and cloud patches components more clearly and concisely - Changed list of patches to fixes * Update rake multirepo:init Use ruby syntax for environment variable Exit if rake init fails on checkout * Typo fix * Update rake index Remove --dry-run Add output message * Refactor rake init Replaced 'print + exit' with equal 'abort' * Update rake mutirepo tasks Add rake reinit Refactor * Formatting * Formatting * Add caution for 'rake multirepo:reinit' * Remove typos in command * Update guides/v2.3/security/google-recaptcha.md Accepted approver's suggestion Co-Authored-By: Shrie Spangler <spangler@adobe.com> * fixed broken link * removing variable and remove link for example * Added JS script name resolution examples * Added note for ece-tools patch process fix (#6004) * Added fix for patch process issue introduced by version scheme change for security only patches in Magento 2.3.2-p2. * Updates yml. Delete unused file. * Fixed typo. * Linting * Grammar and formatting * Trailing spaces * Markdown linting: Enable rule MD036 (emphasis used instead of a header) (#6023) * Added colons to common psuedo-headers * Added colons to less common psuedo headers * Added colons to more less common psuedo headers * Removed emphasis from captions * fix linting problems for text added in 2.3.4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) adds the global navigation menu that links to other documentation sites.
Affected DevDocs pages