Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Cloud 2002.0.22 #5997

Merged
merged 16 commits into from
Nov 15, 2019
Merged

Cloud 2002.0.22 #5997

merged 16 commits into from
Nov 15, 2019

Conversation

meker12
Copy link
Contributor

@meker12 meker12 commented Nov 14, 2019

Purpose of this pull request

  • Added release notes for 2002.0.22
  • Consolidated release notes into one version in the 2.2 directory and replaced the v2.3 file with a symlink
  • Moved release notes to the top-level navigation

Affected DevDocs pages

https://devdocs.magento.com/guides/v2.3/cloud/release-notes/cloud-tools.html

whatsnew
Published the release notes for Magento Commerce Cloud v2002.0.22 .

- Replace v2.3 release notes with symlink
- Add section for 2002.0.22 release notes
- Remove obsolete version information from the Cloud TOC file
- Replace v2.3 release notes with symlink
- Add section for 2002.0.22 release notes
- Remove obsolete version information from the Cloud TOC file
- Fixed merge conflicts
- Moved release notes to H1 in navigation
@meker12 meker12 self-assigned this Nov 14, 2019
@meker12 meker12 added 2.x Internal Dev Differentiates work between community and Magento staff and removed Progress: review labels Nov 14, 2019
Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not run a build. I noticed fluctuating uses of the word module versus package. These are all new, so I would stick with the reference from the repositories. The MCP is a package from the Magento Cloud Suite. Module is used for Magento extensions/modules. Wouldn't want it to become confusing, unless there is a case for the use of module.


- {:.new}<!--MAGECLOUD-4428-->**MSI patches**–Fixes issues that caused indexing errors and performance issues when using default inventory settings for managing stock.

- {:.new}<!--MAGECLOUD-4422-->**Backward Compatibility of new Mail Interfaces**-Fixes a backward incompatibility issue caused by the new `Magento\Framework\Mail\EmailMessageInterface` introduced in {{ site.data.var.ee }} v2.3.3. In the scope of this patch, the new `EmailMessageInterface` inherits from the old `MessageInterface`, and {{ site.data.var.ee }} core modules are reverted to depend on `MessageInterface`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't actually say what MessageInterface is ...like output, data, message, or something. It's not critical, but it can be helpful. I suppose most people using it will know.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually a PHP interface-- so I didn't elaborate. Normally, I'd agree with you, but in this case of a patch description, I think it's OK to leave as is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ agree. This one is about backward-incompatibility, so we can keep it technical with link to an actual code.

- {:.new}<!--MAGECLOUD-4448-->**Catalog pagination does not work on Elasticsearch 6.x**–Fixes a critical issue with search result pagination that affects customers using Elasticsearch 6.x as the catalog search engine.

{:.bs-callout-warning}
You must update to {{ site.data.var.ct }} version 2002.0.22 or later to apply the patches included in Magento Cloud Patches, version 1.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change version to 1.0.0

@@ -17,6 +16,31 @@ The release notes include:
- {:.new}New features
- {:.fix}Fixes and improvements

## v2002.0.22

- {:.new}**Changes to the ece-tools composer package**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please highlight this somehow, so it's better visible VS a regular release line? Something like info block would work.

Copy link
Contributor

@YPyltiai YPyltiai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments. Thanks!

meker12 and others added 2 commits November 14, 2019 11:00
@@ -485,7 +507,7 @@ The ece-tools version 2002.0.11 is required for 2.2.4 compatibility.

## v2002.0.9

{:.bs-callout .bs-callout-info}
{.bs-callout-info}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{.bs-callout-info}
{:.bs-callout-info}

This breaks without the colon.

changes to ece-tools and cloud patches
components more clearly and concisely
- Changed list of patches to fixes
@@ -40,11 +39,9 @@ pages:

- label: Bitbucket integration
url: /cloud/project/bitbucket-integration.html
include_versions: ["2.0"]

- label: GitHub integration
url: /cloud/project/project-integrate-github.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if this is only included in 2.0 and we don't need it, then you have to remove all three lines. Try that!

@@ -269,18 +255,16 @@ pages:

- label: Set up Solr service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all three lines here and anything else where you removed the includes 2.0 only.

Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you get the TOC back in shape, you're good to go.

@meker12
Copy link
Contributor Author

meker12 commented Nov 15, 2019

running tests

@meker12 meker12 merged commit b2b0509 into master Nov 15, 2019
@ghost
Copy link

ghost commented Nov 15, 2019

Hi @meker12, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@meker12 meker12 added the Major Update Significant original updates to existing content label Nov 15, 2019
@hguthrie hguthrie deleted the Cloud-2002.0.22 branch November 15, 2019 14:43
keharper added a commit that referenced this pull request Nov 18, 2019
* Fixed incorrect module dependency examples

* update file extension

* Fix small grammatical issue

  - Missing article

* Fixed incorrect link syntax

* Fix staging

Use double quotes for Build number variable in rake build:stage

* Fix staging

Replace a bash variable with ENV syntax in rake build:stage

* Improving the Range UiComponent

* Improving the Checkbox UiComponent documentation

* magento/devdocs#: Add deleteCustomerAddress mutation API errors

- https://devdocs.magento.com/guides/v2.3/graphql/mutations/delete-customer-address.html

* Adding the widget available options

* Update theme-create.md

* Product availability updates (#5984)

* Added product recs

* Added qualification for Google extension

* magento/devdocs#: Add updateCustomerAddress mutation API errors

- https://devdocs.magento.com/guides/v2.3/graphql/mutations/update-customer-address.html

* Editing for grammar

* Editing for grammar

* Table formatting

* Grammar

* magento/devdocs#: Extends information about creating a dynamic row system config.

- https://devdocs.magento.com/guides/v2.2/ext-best-practices/tutorials/dynamic-row-system-config.html
- https://devdocs.magento.com/guides/v2.3/ext-best-practices/tutorials/dynamic-row-system-config.html

* Add site switcher to the header (#5983)

* Add site switcher to the header

* Change site-nav.html to add the button

* Add contributor metadata info

* Removed workflows file

* Change wording

Change mention of notation to "attribution" and implement limitation on accepted links per Jeff's review

* Added PHP note

added a note regarding required PHP setting for Google reCAPTCHA. This update was vetted and approved by Rick Tempesta.

* Small grammar fix

* [ImgBot] Optimize images

/common/images/ext-best-practices/dynamic-rows-config-result.png -- 61.37kb -> 30.32kb (50.59%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

* Update database-caching.md

Fix Identation of XML code.

* Adding new example

New example using SearchCriteria with getList

* Update create-cache-type.md

Namespace not is in default model used by Magento FrameWork

* Update lifecycle.md

Alter definition of class, not good practice.

* Add rake index with dry run

* Cloud 2002.0.22 (#5997)

- Consolidate versioned release notes to one topic
- Replace v2.3 release notes with symlink
- Add section for 2002.0.22 release notes
- Remove obsolete version information from the Cloud TOC file
- Revised release notes to explain
changes to ece-tools and cloud patches
components more clearly and concisely
- Changed list of patches to fixes

* Update rake multirepo:init

Use ruby syntax for environment variable
Exit if rake init fails on checkout

* Typo fix

* Update rake index

Remove --dry-run
Add output message

* Refactor rake init

Replaced 'print + exit' with equal 'abort'

* Update rake mutirepo tasks

Add rake reinit
Refactor

* Formatting

* Formatting

* Add caution for 'rake multirepo:reinit'

* Remove typos in command

* Update guides/v2.3/security/google-recaptcha.md

Accepted approver's suggestion

Co-Authored-By: Shrie Spangler <spangler@adobe.com>

* fixed broken link
keharper added a commit that referenced this pull request Nov 19, 2019
* Update first-time-setup-import-import.md

* adding new information from stopwords elasticsearch

* settings

* settings

* settings spaces

* settings by MD029

* settings by MD029

* adding variable from github url tree

* adding url variable

* adding fix MD009

* Updated repo path

* Fixed double quotes.

* Fixed incorrect module dependency examples

* update file extension

* Fix small grammatical issue

  - Missing article

* Fixed incorrect link syntax

* Fix staging

Use double quotes for Build number variable in rake build:stage

* Fix staging

Replace a bash variable with ENV syntax in rake build:stage

* Improving the Range UiComponent

* Improving the Checkbox UiComponent documentation

* magento/devdocs#: Add deleteCustomerAddress mutation API errors

- https://devdocs.magento.com/guides/v2.3/graphql/mutations/delete-customer-address.html

* Adding the widget available options

* Update theme-create.md

* Product availability updates (#5984)

* Added product recs

* Added qualification for Google extension

* magento/devdocs#: Add updateCustomerAddress mutation API errors

- https://devdocs.magento.com/guides/v2.3/graphql/mutations/update-customer-address.html

* Editing for grammar

* Editing for grammar

* Table formatting

* Grammar

* magento/devdocs#: Extends information about creating a dynamic row system config.

- https://devdocs.magento.com/guides/v2.2/ext-best-practices/tutorials/dynamic-row-system-config.html
- https://devdocs.magento.com/guides/v2.3/ext-best-practices/tutorials/dynamic-row-system-config.html

* Add site switcher to the header (#5983)

* Add site switcher to the header

* Change site-nav.html to add the button

* Add contributor metadata info

* Removed workflows file

* Change wording

Change mention of notation to "attribution" and implement limitation on accepted links per Jeff's review

* Added PHP note

added a note regarding required PHP setting for Google reCAPTCHA. This update was vetted and approved by Rick Tempesta.

* Small grammar fix

* [ImgBot] Optimize images

/common/images/ext-best-practices/dynamic-rows-config-result.png -- 61.37kb -> 30.32kb (50.59%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

* Update database-caching.md

Fix Identation of XML code.

* Adding new example

New example using SearchCriteria with getList

* Update create-cache-type.md

Namespace not is in default model used by Magento FrameWork

* Update lifecycle.md

Alter definition of class, not good practice.

* Add rake index with dry run

* Cloud 2002.0.22 (#5997)

- Consolidate versioned release notes to one topic
- Replace v2.3 release notes with symlink
- Add section for 2002.0.22 release notes
- Remove obsolete version information from the Cloud TOC file
- Revised release notes to explain
changes to ece-tools and cloud patches
components more clearly and concisely
- Changed list of patches to fixes

* Update rake multirepo:init

Use ruby syntax for environment variable
Exit if rake init fails on checkout

* Typo fix

* Update rake index

Remove --dry-run
Add output message

* Refactor rake init

Replaced 'print + exit' with equal 'abort'

* Update rake mutirepo tasks

Add rake reinit
Refactor

* Formatting

* Formatting

* Add caution for 'rake multirepo:reinit'

* Remove typos in command

* Update guides/v2.3/security/google-recaptcha.md

Accepted approver's suggestion

Co-Authored-By: Shrie Spangler <spangler@adobe.com>

* fixed broken link

* removing variable and remove link for example

* Added JS script name resolution examples

* Added note for ece-tools patch process fix (#6004)

* Added fix for patch process issue introduced
  by version scheme change for 
  security only patches in Magento 2.3.2-p2.

* Updates yml. Delete unused file.

* Fixed typo.

* Linting

* Grammar and formatting

* Trailing spaces

* Markdown linting: Enable rule MD036 (emphasis used instead of a header) (#6023)

* Added colons to common psuedo-headers

* Added colons to less common psuedo headers

* Added colons to more less common psuedo headers

* Removed emphasis from captions

* fix linting problems for text added in 2.3.4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants