Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AdminGws support to MSI. #2837

Closed
wants to merge 1 commit into from
Closed

Add AdminGws support to MSI. #2837

wants to merge 1 commit into from

Conversation

nmalevanec
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. none.

Manual testing scenarios (*)

  1. Create additional website.
  2. Create additional stock and source for new website.
  3. Create product with default source and custom assigned.
  4. Create admin user with restriction for main website.
  5. Navigate to source grid and verify default source is not visible.
  6. Navigate to stock grid and verify default stock is not visible.
  7. Navigate to product grid and verify only custom source and stock visible in product row.
  8. Open product edit page and verify only custom source and stock visible in product row.
  9. Add some changes to custom source and save product.
  10. Login with admin user without restrictions.
  11. Navigate to product edit page and verify only custom source has changed.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@smoskaluk
Copy link

smoskaluk commented Feb 25, 2020

Hi @nmalevanec , I've got such error during placing order from admin:
Steps to reproduce:

  1. Create additional website.
  2. Create additional stock and source for new website.
  3. Create product with inventory on custom source.
  4. Create admin user with restriction for main website.
  5. Try to place order from admin with this product

CRITICAL: Error: Call to undefined method Magento\Sales\Api\Data\OrderExtension::setBaseCustomerBalanceAmount() in ../app/code/Magento/CustomerBalance/Model/Plugin/OrderRepository.php:49
Stack trace:
#0 /lib/internal/Magento/Framework/Interception/Interceptor.php(146): Magento\CustomerBalance\Model\Plugin\OrderRepository->afterGet(Object(Magento\Sales\Model\OrderRepository\Interceptor), Object(Magento\Sales\Model\Order\Interceptor), '1')
#1 /lib/internal/Magento/Framework/Interception/Interceptor.php(153): Magento\Sales\Model\OrderRepository\Interceptor->Magento\Framework\Interception{closure}('1')
#2 /generated/code/Magento/Sales/Model/OrderRepository/Interceptor.php(26): Magento\Sales\Model\OrderRepository\Interceptor->___callPlugins('get', Array, Array)
#3 /app/code/Magento/Sales/Controller/Adminhtml/Order.php(155): Magento\Sales\Model\OrderRepository\Interceptor->get('1')
#4 /app/code/Magento/Sales/Controller/Adminhtml/Order/View.php(26): Magento\Sales\Controller\Adminhtml\Order->_initOrder()
#5 /generated/code/Magento/SalesArchive/Controller/Adminhtml/Order/View/Interceptor.php(24): Magento\Sales\Controller\Adminhtml\Order\View->execute()
#6 /lib/internal/Magento/Framework/App/Action/Action.php(107): Magento\SalesArchive\Controller\Adminhtml\Order\View\Interceptor->execute()
#7 /app/code/Magento/Backend/App/AbstractAction.php(231): Magento\Framework\App\Action\Action->dispatch(Object(Magento\Framework\App\Request\Http))
#8 /lib/internal/Magento/Framework/Interception/Interceptor.php(58): Magento\Backend\App\AbstractAction->dispatch(Object(Magento\Framework\App\Request\Http))
#9 /lib/internal/Magento/Framework/Interception/Interceptor.php(138): Magento\SalesArchive\Controller\Adminhtml\Order\View\Interceptor->___callParent('dispatch', Array)
#10 /app/code/Magento/Backend/App/Action/Plugin/Authentication.php(143): Magento\SalesArchive\Controller\Adminhtml\Order\View\Interceptor->Magento\Framework\Interception{closure}(Object(Magento\Framework\App\Request\Http))
#11 /lib/internal/Magento/Framework/Interception/Interceptor.php(135): Magento\Backend\App\Action\Plugin\Authentication->aroundDispatch(Object(Magento\SalesArchive\Controller\Adminhtml\Order\View\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#12 /lib/internal/Magento/Framework/Interception/Interceptor.php(153): Magento\SalesArchive\Controller\Adminhtml\Order\View\Interceptor->Magento\Framework\Interception{closure}(Object(Magento\Framework\App\Request\Http))
#13 /generated/code/Magento/SalesArchive/Controller/Adminhtml/Order/View/Interceptor.php(39): Magento\SalesArchive\Controller\Adminhtml\Order\View\Interceptor->___callPlugins('dispatch', Array, NULL)
#14 /lib/internal/Magento/Framework/App/FrontController.php(162): Magento\SalesArchive\Controller\Adminhtml\Order\View\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
#15 /lib/internal/Magento/Framework/App/FrontController.php(99): Magento\Framework\App\FrontController->processRequest(Object(Magento\Framework\App\Request\Http), Object(Magento\SalesArchive\Controller\Adminhtml\Order\View\Interceptor))
#16 /lib/internal/Magento/Framework/Interception/Interceptor.php(58): Magento\Framework\App\FrontController->dispatch(Object(Magento\Framework\App\Request\Http))
#17 /lib/internal/Magento/Framework/Interception/Interceptor.php(138): Magento\Framework\App\FrontController\Interceptor->___callParent('dispatch', Array)
#18 /lib/internal/Magento/Framework/Interception/Interceptor.php(153): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception{closure}(Object(Magento\Framework\App\Request\Http))
#19 /generated/code/Magento/Framework/App/FrontController/Interceptor.php(26): Magento\Framework\App\FrontController\Interceptor->___callPlugins('dispatch', Array, Array)
#20 /lib/internal/Magento/Framework/App/Http.php(116): Magento\Framework\App\FrontController\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
#21 /generated/code/Magento/Framework/App/Http/Interceptor.php(24): Magento\Framework\App\Http->launch()
#22 /lib/internal/Magento/Framework/App/Bootstrap.php(260): Magento\Framework\App\Http\Interceptor->launch()
#23 /index.php(39): Magento\Framework\App\Bootstrap->run(Object(Magento\Framework\App\Http\Interceptor))
#24 {main} [] []

@nmalevanec
Copy link
Contributor Author

@smoskaluk, I wasn't able to reproduce described issue. Followed the steps - order placed successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants