Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exported Excel with negative number can't be opened by MS Office #11729

Closed
hauso opened this issue Oct 25, 2017 · 3 comments
Closed

Exported Excel with negative number can't be opened by MS Office #11729

hauso opened this issue Oct 25, 2017 · 3 comments
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@hauso
Copy link
Contributor

hauso commented Oct 25, 2017

Preconditions

XML excel generator class contain error causing file can't be opened by MS Office.
In Open Office is file opened without problem

  1. Magento 2.x version + MS Office XML handler

Steps to reproduce

  1. Generate some XML export with negative value (eg. quantity)
  2. Try to open it with Office XML handler

Expected result

  1. Open export file

Actual result

  1. File do not open correctly and Office's error log is created containing information about incorrect value eg.:

XML ERROR in Table
REASON: Bad Value
FILE: C:\Tomas\products_20171025134557.xml
GROUP: Cell
TAG: Data
VALUE: -1

I tested Microsoft Office Professional Plus 2013 and OpenOffice Calc 4.1.3 only.
Open Office can open file without problem, MS Office do not open file and create error report.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 25, 2017
hauso added a commit to hauso/magento2 that referenced this issue Oct 25, 2017
@hauso
Fix magento#11729 - negative value in excel export
1d3779f 
$dataType need to be set to 'String' instead 'Number' when value contain space (eg negative number with added space)
@hauso hauso mentioned this issue Oct 25, 2017
Merged
@hauso hauso mentioned this issue Oct 26, 2017
Merged
hauso added a commit to hauso/magento2 that referenced this issue Oct 26, 2017
@hauso
Fix magento#11729 - negative value in excel export[M2.1]
0c660ce
@hauso hauso mentioned this issue Oct 26, 2017
Merged
okorshenko pushed a commit that referenced this issue Oct 27, 2017
@avoelkl
MAGETWO-82851: Fix #11729 - negative value in excel export [M2.2] #11757
2a84261 


 - Merge Pull Request #11757 from hauso/magento2:patch-2
 - Merged commits:
   1. 2aa22d4
okorshenko pushed a commit that referenced this issue Oct 27, 2017
@ishakhsuvarov
MAGETWO-82851: Fix #11729 - negative value in excel export [M2.2] #11757
010322b
@magento-team magento-team added 2.2.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Oct 27, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-82851

magento-team pushed a commit that referenced this issue Oct 31, 2017
@avoelkl
MAGETWO-82959: Fix #11729 - negative value in excel export[M2.1] #11758
cd1c1ac 
 - Merge Pull Request #11758 from hauso/magento2:patch-3
 - Merged commits:
   1. 0c660ce
magento-team pushed a commit that referenced this issue Oct 31, 2017
@ishakhsuvarov
MAGETWO-82959: Fix #11729 - negative value in excel export[M2.1] #11758
998792c
magento-team pushed a commit that referenced this issue Oct 31, 2017
@ishakhsuvarov
Merge pull request #1640 from magento-engcom/2.1-develop-prs
a518a12 
[EngCom] Public Pull Requests - 2.1-develop
 - MAGETWO-82980: [Backport 2.1-develop] Fix AcountManagementTest unit test fail randomly #11606
 - MAGETWO-82959: Fix #11729 - negative value in excel export[M2.1] #11758
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-82959

okorshenko pushed a commit that referenced this issue Oct 31, 2017
@avoelkl
MAGETWO-82960: Fix #11729 - negative value in excel export #11730
204c726 
 - Merge Pull Request #11730 from hauso/magento2:patch-1
 - Merged commits:
   1. 1d3779f
okorshenko pushed a commit that referenced this issue Oct 31, 2017
MAGETWO-82960: Fix #11729 - negative value in excel export #11730
63cf998
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-82960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@magento-team @hauso @magento-engcom-team