Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #11729 - negative value in excel export[M2.1] #11758

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Fix #11729 - negative value in excel export[M2.1] #11758

merged 1 commit into from
Oct 31, 2017

Conversation

hauso
Copy link
Contributor

@hauso hauso commented Oct 26, 2017

$dataType need to be set to 'String' instead 'Number' when value contain space (eg negative number with added space)

Fixed problem with negative values in exported XML file

Description

Added correction of dataType for negative numbers

Fixed Issues (if relevant)

  1. Exported Excel with negative number can't be opened by MS Office #11729: Exported Excel with negative number can't be opened by MS Office

Manual testing scenarios

  1. Generate export with negative value
  2. Open thru Microsoft Office XML handler with Microsoft Office Professional Plus 2013

Contribution checklist

  • not automated tests was provided

@hauso hauso mentioned this pull request Oct 26, 2017
Merged
@avoelkl avoelkl self-assigned this Oct 26, 2017
@avoelkl avoelkl added this to the October 2017 milestone Oct 29, 2017
@avoelkl
Copy link
Contributor

avoelkl commented Oct 29, 2017

For reference: This is the PR that was already merged into 2.2-develop
#11757

@magento-team magento-team merged commit 0c660ce into magento:2.1-develop Oct 31, 2017
magento-team pushed a commit that referenced this pull request Oct 31, 2017
@ishakhsuvarov
MAGETWO-82959: Fix #11729 - negative value in excel export[M2.1] #11758
998792c
magento-team pushed a commit that referenced this pull request Oct 31, 2017
@ishakhsuvarov
Merge pull request #1640 from magento-engcom/2.1-develop-prs
a518a12 
[EngCom] Public Pull Requests - 2.1-develop
 - MAGETWO-82980: [Backport 2.1-develop] Fix AcountManagementTest unit test fail randomly #11606
 - MAGETWO-82959: Fix #11729 - negative value in excel export[M2.1] #11758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@avoelkl avoelkl

Labels
bugfix Progress: accept Release Line: 2.1
Projects
None yet
Milestone
October 2017
Development

Successfully merging this pull request may close these issues.
3 participants
@hauso @avoelkl @magento-team