Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readiness Check - AngularJS cancels requests, fails check #1640

Closed
frehner opened this issue Aug 10, 2015 · 4 comments
Closed

Readiness Check - AngularJS cancels requests, fails check #1640

frehner opened this issue Aug 10, 2015 · 4 comments
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@frehner
Copy link
Contributor

frehner commented Aug 10, 2015

I'm running Magento2 through Docker right now, and I'm not on a very powerful machine which means that requests take about 1 second or so to process. The problem I'm having is that the readiness check's AngularJS code appears to cancel requests after 3 seconds, which causes the checks to fail for me for the most part.

Occasionally one or a couple of the readiness checks processes in time and I pass that particular check, but the others didn't process in time so overall my server fails the readiness check. I'm stuck on the readiness check page even though all the checks do actually pass if the server responds in time.

I can see a couple of solutions to this.

  1. Give the option or show where we can change the AngularJS timeout, so it can be longer.
  2. Give the option to run checks individually instead of sending all the requests at the same time.
  3. Make the "Try Again" button check only the ones that have failed, instead of checking all of them at the same time.

This isn't a big deal, since Magento2 in a production environment wouldn't be on this constrained of a machine, but it does make it so that I can't test and prototype on my local machine.

Any thoughts?

@piotrekkaminski
Copy link
Contributor

@tanya-soroka can you look into that?

@mazhalai
Copy link
Contributor

mazhalai commented Oct 5, 2015

@frehner we are working on this. Ticket # MAGETWO-43385

@mazhalai mazhalai added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 5, 2015
@frehner
Copy link
Contributor Author

frehner commented Oct 5, 2015

Thanks, glad to know!

@mazhalai
Copy link
Contributor

@frehner this issue has been fixed in 2.0.0. Closing this issue. Please open a new one if it persists.

magento-team pushed a commit that referenced this issue Oct 31, 2017
[EngCom] Public Pull Requests - 2.1-develop
 - MAGETWO-82980: [Backport 2.1-develop] Fix AcountManagementTest unit test fail randomly #11606
 - MAGETWO-82959: Fix #11729 - negative value in excel export[M2.1] #11758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

4 participants