Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Free shiping coupon usage is not tracked #3506

Closed
Fel1xx opened this issue Feb 22, 2016 · 2 comments
Closed

Free shiping coupon usage is not tracked #3506

Fel1xx opened this issue Feb 22, 2016 · 2 comments
Assignees
@NadiyaS
Labels
bug report Component: Checkout Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@Fel1xx
Copy link

Fel1xx commented Feb 22, 2016

Hi.

Found an issue that usage of free shipping coupons is not tracked correctly. Steps to reproduce:

  1. Create a cart rule with "Free Shipping" in actions and Uses per Coupon and Uses per Customer set to 1.
  2. Make sure that discount amount is set to 0.
  3. Generate some coupon code
  4. Place an order with generated coupon on store front.
  5. Try to apply this coupon again and it will be applied (it shouldn't!).

Tested on 2.0.2. Seems it comes from https://github.com/magento/magento2/blob/develop/app/code/Magento/SalesRule/Observer/SalesOrderAfterPlaceObserver.php#L60. It bypasses coupon usage processing with $order->getDiscountAmount() == 0 if no discount amount was applied but we just allow free shipping, not some particular discount.
@olysenko
Copy link

Hi @Fel1xx ,
thank you for reporting this issue, internal ticket was created MAGETWO-55342

@NadiyaS NadiyaS added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jul 13, 2016
@vkorotun vkorotun removed the CS label Aug 4, 2016
@danslo danslo mentioned this issue Sep 21, 2016
Closed
This was referenced Sep 21, 2016
Closed
Closed
mmansoor-magento pushed a commit that referenced this issue Oct 5, 2016
MAGETWO-55342: [GITHUB] Free shiping coupon usage is not tracked #3506
e8ef9ce
mmansoor-magento pushed a commit that referenced this issue Oct 5, 2016
@MomotenkoNatalia
Merge pull request #464 from magento-folks/bugs
2cacd80 
Fixed issues:
- MAGETWO-56938: CLONE - [Github] API salesOrderRepositoryV1 can't create shipping address #5544
- MAGETWO-55342: [GITHUB] Free shiping coupon usage is not tracked #3506
- MAGETWO-59137: It's impossible to create a catalog price rule
- MAGETWO-59090: [Github] Admin can't reset password for more than one customer #5260
- MAGETWO-58182: [Github] Minicart item count is not updated if switch from https to http #6487
@sdzhepa
Copy link
Contributor

sdzhepa commented Oct 6, 2016 •
edited
Loading

@Fel1xx
Fix for this issue was delivered to develop branch. Pls feel free to check it in develop and reopen if need

  • Fix for Magento 2.1 will be delivered later in scope of internal ticket 'MAGETWO-59243'
  • Fix for Magento 2.0 will be delivered later in scope of internal ticket 'MAGETWO-59245'

@sdzhepa sdzhepa closed this as completed Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NadiyaS NadiyaS

Labels
bug report Component: Checkout Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@sdzhepa @veloraven @Fel1xx @vkorotun @olysenko @MomotenkoNatalia @NadiyaS