Optimization on Weee tax calculation #464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just load the needed weee attributs and avoid a sort. The difference is really big when you have a lot of attributs
|
Thanks @dorn ! |
|
You're welcome, hope it will help you :) |
magento-team
pushed a commit
that referenced
this pull request
Mar 19, 2016
[Troll & Dragons] Bugfixes
mmansoor-magento
pushed a commit
that referenced
this pull request
Oct 5, 2016
Fixed issues: - MAGETWO-56938: CLONE - [Github] API salesOrderRepositoryV1 can't create shipping address #5544 - MAGETWO-55342: [GITHUB] Free shiping coupon usage is not tracked #3506 - MAGETWO-59137: It's impossible to create a catalog price rule - MAGETWO-59090: [Github] Admin can't reset password for more than one customer #5260 - MAGETWO-58182: [Github] Minicart item count is not updated if switch from https to http #6487
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just load the needed weee attributes and avoid a sort which does not seem useful.
The difference is really big when you have a lot of attributes (1k) and a lot of products in the cart (>15).
This is a workaround for the issue I submitted (Issue #460)